remove OpenTsdbError in favor of TimeseriesError - #21
Merged
Conversation
hachikuji
reviewed
Jan 6, 2026
hachikuji
left a comment
Contributor
There was a problem hiding this comment.
I had wondered if we could just use Error for the public-facing error. That seems conventional in rust. Users can import as TimeSeriesError when there is a conflict.
Contributor
Author
|
@hachikuji I don't feel too strongly, I can make that change back. Just seems like we'll have a lot of |
Contributor
|
Yeah, that is true. But probably unlikely we would have more than one or two in scope at any time. I feel like rust offers enough alias flexibility like using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #17 we now have two errors types for
timeseriesthis consolidates the two and renamesError->TimseriesErrorso it makes codesearch easier going forwardRelated Issues
N/A
Test Plan
Ran existing tests
Checklist
cargo fmtandcargo clippypass