Skip to content

remove OpenTsdbError in favor of TimeseriesError - #21

Merged
agavra merged 1 commit into
mainfrom
conoslidate_errors
Jan 6, 2026
Merged

remove OpenTsdbError in favor of TimeseriesError#21
agavra merged 1 commit into
mainfrom
conoslidate_errors

Conversation

@agavra

@agavra agavra commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Summary

After #17 we now have two errors types for timeseries this consolidates the two and renames Error -> TimseriesError so it makes codesearch easier going forward

Related Issues

N/A

Test Plan

Ran existing tests

Checklist

  • Tests added/updated
  • cargo fmt and cargo clippy pass
  • Documentation updated (if applicable)

@agavra
agavra merged commit 72cd9d7 into main Jan 6, 2026
1 check passed
@agavra
agavra deleted the conoslidate_errors branch January 6, 2026 20:23

@hachikuji hachikuji left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had wondered if we could just use Error for the public-facing error. That seems conventional in rust. Users can import as TimeSeriesError when there is a conflict.

@agavra

agavra commented Jan 6, 2026

Copy link
Copy Markdown
Contributor Author

@hachikuji I don't feel too strongly, I can make that change back. Just seems like we'll have a lot of Error classes in one code base 😅

@hachikuji

Copy link
Copy Markdown
Contributor

Yeah, that is true. But probably unlikely we would have more than one or two in scope at any time. I feel like rust offers enough alias flexibility like usingtimeseries::Error directly or timeseries::Error as TimeSeriesError that the simpler naming is preferable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants