Add basic sequence number bookkeeping - #28
Merged
Merged
Conversation
This patch implements the codec logic for log record keys and values. It also modifies the storage RFC with a revised escaping scheme. We use 0x00 as the delimiter between the key and the sequence in the composite key and 0x01 as the escape character. Additionally, we reserve 0xFF to specify the end of a prefix range query. For example, to find all log entries matching the key prefix "/foo", we we would set the start bound to "/foo" + 0x00 and the end bound to "/foo" + 0xFF.
agavra
approved these changes
Jan 7, 2026
agavra
left a comment
agavra
left a comment
Contributor
There was a problem hiding this comment.
LGTM pending the weird thing with changes being puled in for timeseries. not sure what's up with that
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch contains basic sequence number initialization and allocation logic. For now, the logic is synchronous. Eventually we can move it to a separate thread so that we are unlikely to block on sequence number allocation.