side-channel for collection of traces - #417
Open
rodesai wants to merge 1 commit into
Open
Conversation
We use the tracing crate throughout the codebase to collect traces However out-of-the-box it doesn't let you distinguish between perf and functional diagnostic use cases. Traces are very useful for being able to understand where some logical operaiton spends time. However when we enable debug traces we bring along very verbose debug logs that make the traces harder to grok from the log and can themselves hinder performance. This PR addresses this by adding a framework for recording just timing traces and toggling this at either the process level or per-operation. The traces go to a file in chrome format so they can be visualized using Chrome or Perfetto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We use the tracing crate throughout the codebase to collect traces However out-of-the-box it doesn't let you distinguish between perf and functional diagnostic use cases. Traces are very useful for being able to understand where some logical operaiton spends time. However when we enable debug traces we bring along very verbose debug logs that make the traces harder to grok from the log and can themselves hinder performance. This PR addresses this by adding a framework for recording just timing traces and toggling this at either the process level or per-operation. The traces go to a file in chrome format so they can be visualized using Chrome or Perfetto, e.g:
Checklist
cargo fmtandcargo clippypass