Timeseries: add WarmStorage trait for block-cache warming - #508
Merged
Conversation
Add a WarmStorage trait to the native SlateDB storage layer that warms the block cache for a set of time buckets. A blanket impl covers the handles whose Db exposes a cache manager (the writer Db and the read-only DbReader); DbSnapshot deliberately has no impl since it carries neither the manifest (DbMetadataOps) nor warm_sst (DbCacheManagerOps). StorageReaderInner::warm resolves the requested buckets to the SSTs live in the current manifest (each bucket is its own segment per RFC-0024) and warms, per SST, the filters, the index, and the data blocks of the index record types (series dictionary, forward index, inverted index); sample data blocks are included only when requested. SSTs are warmed with a bounded fan-out of 16, and a cancellation token aborts the warm promptly without surfacing an error. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a WarmStorage trait to the native SlateDB storage layer that warms the block cache for a set of time buckets. A blanket impl covers the handles whose DB exposes a cache manager.
Test Plan
unit tests
Checklist
cargo fmtandcargo clippypass