Timeseries: fix stale cache warmer doc comments - #512
Merged
Conversation
The CacheWarmerConfig doc comment still described the original warmer (scanning recent key ranges through the reader, "a temporary workaround until SlateDB's CacheManager is available"). #509 switched the implementation to drive SlateDB's cache manager but left the comments behind. Update them to describe the current behavior. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CacheWarmerConfigdoc comment still described the pre-#509 warmer — scanning recent time bucket key ranges through the storage reader as "a temporary workaround until SlateDB's CacheManager is available". #509 switched the implementation to drive SlateDB's cache manager (warm_sstover the SSTs backing recent buckets) but left the comments behind.Comment-only change;
cargo check -p opendata-timeseriespasses.🤖 Generated with Claude Code