build: bump vllm-openai-cpu base image to v0.25.0 - #498
Conversation
📝 WalkthroughWalkthroughThe Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
410c5cf to
ac25523
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@vllm/Containerfile`:
- Line 5: Update the Containerfile’s FROM declaration to pin
vllm/vllm-openai-cpu to its immutable manifest digest, replacing the mutable
v0.25.0 tag while preserving the selected image.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 7141cefd-6f41-4216-a327-dc46e52845be
📒 Files selected for processing (1)
vllm/Containerfile
| # Reference: https://hub.docker.com/r/vllm/vllm-openai-cpu | ||
|
|
||
| FROM vllm/vllm-openai-cpu:v0.23.0 | ||
| FROM vllm/vllm-openai-cpu:v0.25.0 |
There was a problem hiding this comment.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Containerfile =="
git ls-files -- vllm/Containerfile
wc -l vllm/Containerfile
cat -n vllm/Containerfile | sed -n '1,40p'
echo "== Any digest-pinned vllm base image references =="
rg -n --no-heading 'FROM\s+vllm/vllm-openai-cpu:.*`@sha256`:|FROM\s+vllm/vllm-openai-cpu:[^[:space:]]+' vllm/Containerfile .github . || trueRepository: opendatahub-io/ogx-distribution
Length of output: 1965
Pin the vLLM base image by digest.
vllm/vllm-openai-cpu:v0.25.0 is a mutable supply-chain boundary; a retagged image or compromised publish path can silently change the runtime contents (CWE-494). Lock it to the manifest digest instead of the tag.
Patch
-FROM vllm/vllm-openai-cpu:v0.25.0
+FROM vllm/vllm-openai-cpu:v0.25.0@sha256:<manifest-digest>🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@vllm/Containerfile` at line 5, Update the Containerfile’s FROM declaration to
pin vllm/vllm-openai-cpu to its immutable manifest digest, replacing the mutable
v0.25.0 tag while preserving the selected image.
Source: Path instructions
|
Tick the box to add this pull request to the merge queue (same as
|
|
@nathan-weinberg: The following test has Succeeded: OCI Artifact Browser URLInspecting Test Artifacts ManuallyTo inspect your test artifacts manually, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:ogx-core-functional-its-zmpt8 |
Summary
v0.23.0tov0.25.0invllm/ContainerfileTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit