fix: remove hard-coded default Postgres credentials from config - #501
Conversation
|
Warning Review limit reached
Next review available in: 56 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
Remove default `ogx` values for POSTGRES_DB, POSTGRES_USER, and POSTGRES_PASSWORD from build.yaml so the distributed config ships with empty defaults, forcing operators to supply credentials explicitly. Parameterize the CI actions (setup-postgres, setup-server) and smoke test psql commands so tests continue using the same `ogx` credentials via input defaults and shell parameter expansion. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3206e12 to
3ae08a1
Compare
|
@nathan-weinberg: The following test has Succeeded: OCI Artifact Browser URLInspecting Test Artifacts ManuallyTo inspect your test artifacts manually, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:ogx-core-functional-its-n2zmb |
Summary
ogxvalues forPOSTGRES_DB,POSTGRES_USER, andPOSTGRES_PASSWORDfrombuild/build.yamlso the distributed config ships with empty defaults, forcing operators to supply credentials explicitly (CWE-798)postgres_user,postgres_password,postgres_dbinputs (defaulting toogx) to thesetup-postgresandsetup-serverCI actions so existing tests continue using the same credentialspsql -U ogx -d ogxcalls intests/smoke.shto use shell variable expansion withogxfallback defaultsTest plan
pre-commit run --all-filespasses (verified locally)ogxvia input defaults)ogx)POSTGRES_DB,POSTGRES_USER, andPOSTGRES_PASSWORDenv vars🤖 Generated with Claude Code