Skip to content

fix: remove hard-coded default Postgres credentials from config - #501

Merged
derekhiggins merged 4 commits into
opendatahub-io:mainfrom
nathan-weinberg:RHAIENG-5592
Jul 16, 2026
Merged

fix: remove hard-coded default Postgres credentials from config#501
derekhiggins merged 4 commits into
opendatahub-io:mainfrom
nathan-weinberg:RHAIENG-5592

Conversation

@nathan-weinberg

Copy link
Copy Markdown
Collaborator

Summary

  • Removes default ogx values for POSTGRES_DB, POSTGRES_USER, and POSTGRES_PASSWORD from build/build.yaml so the distributed config ships with empty defaults, forcing operators to supply credentials explicitly (CWE-798)
  • Adds postgres_user, postgres_password, postgres_db inputs (defaulting to ogx) to the setup-postgres and setup-server CI actions so existing tests continue using the same credentials
  • Parameterizes hard-coded psql -U ogx -d ogx calls in tests/smoke.sh to use shell variable expansion with ogx fallback defaults

Test plan

  • pre-commit run --all-files passes (verified locally)
  • CI smoke tests pass (setup-postgres and setup-server actions supply ogx via input defaults)
  • CI integration tests pass (smoke.sh shell defaults fall back to ogx)
  • Deployers who relied on image defaults will now need to explicitly set POSTGRES_DB, POSTGRES_USER, and POSTGRES_PASSWORD env vars

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@mergify[bot], you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 49cba680-dc52-4001-9072-63c6e5d3dc4f

📥 Commits

Reviewing files that changed from the base of the PR and between c6da989 and bcdd090.

📒 Files selected for processing (6)
  • .github/actions/setup-postgres/action.yml
  • .github/actions/setup-server/action.yml
  • Containerfile
  • build/build.yaml
  • distribution/config.yaml
  • tests/smoke.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mergify

mergify Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

⚠️ Heads up! This PR modifies Containerfile.
A corresponding change may be needed in the Konflux Dockerfile: https://github.com/red-hat-data-services/ogx-distribution/blob/main/Dockerfile.konflux
Please verify if the changes need to be synchronized.

Remove default `ogx` values for POSTGRES_DB, POSTGRES_USER, and
POSTGRES_PASSWORD from build.yaml so the distributed config ships with
empty defaults, forcing operators to supply credentials explicitly.

Parameterize the CI actions (setup-postgres, setup-server) and smoke
test psql commands so tests continue using the same `ogx` credentials
via input defaults and shell parameter expansion.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@rhods-ci-bot

Copy link
Copy Markdown

@nathan-weinberg: The following test has Succeeded:

OCI Artifact Browser URL

View in Artifact Browser

Inspecting Test Artifacts Manually

To inspect your test artifacts manually, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/opendatahub/odh-ci-artifacts:ogx-core-functional-its-n2zmb

@nathan-weinberg
nathan-weinberg requested a review from a team July 15, 2026 17:13
@derekhiggins
derekhiggins merged commit e93ce4a into opendatahub-io:main Jul 16, 2026
13 checks passed
@nathan-weinberg
nathan-weinberg deleted the RHAIENG-5592 branch July 16, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants