ci: stage lockfiles by glob in release-branch commit - #572
Open
mfleader wants to merge 3 commits into
Open
Conversation
The "Commit and push" step lists distribution/requirements-lock-konflux.txt literally, but that file exists only when RHAI_INDEX_URL is set in build/build.env. A branch created from main has the variable empty, so the workflow fails on the missing pathspec. Stage lockfiles by the glob distribution/requirements-lock*.txt that update-lockfiles.yml already uses; gen_lockfile.py always writes at least one matching file. Signed-off-by: Matthew F Leader <mleader@redhat.com>
Contributor
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
nathan-weinberg
approved these changes
Aug 21, 2026
nathan-weinberg
left a comment
nathan-weinberg
left a comment
Collaborator
There was a problem hiding this comment.
LGTM but I'd like @eoinfennessy to weigh in as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The create-or-update-release-branch workflow's "Commit and push" step lists distribution/requirements-lock-konflux.txt literally, but that file exists only when RHAI_INDEX_URL is set in build/build.env. A branch created from main has the variable empty, so the workflow fails on the missing pathspec. Stage lockfiles by the glob distribution/requirements-lock*.txt that update-lockfiles.yml already uses; gen_lockfile.py always writes at least one matching file.
Failing run: https://github.com/opendatahub-io/ogx-distribution/actions/runs/32293144386
How Has This Been Tested?
The failing run above reproduces the missing-pathspec error; the glob matches the requirements-lock.txt that every branch has, so git add cannot fail on a missing path.
Test Impact
None. The change modifies only the create-or-update-release-branch workflow's git add step; no test files or test infrastructure are affected.