feat: add topic element activities#3439
Merged
maudetes merged 7 commits intoopendatateam:masterfrom Sep 23, 2025
Merged
Conversation
abulte
commented
Sep 17, 2025
| if not TopicEditPermission(topic).can(): | ||
| apiv2.abort(403, "Forbidden") | ||
|
|
||
| # TODO: should we ignore activity creation here? |
Contributor
Author
There was a problem hiding this comment.
This will create a lot of deleted activities (and probably crash since it is synchronous) if we empty a universe Topic. I'm not sure we should introduce an exception here to prevent that, WDYT?
Emptying a universe crashes anyway 😬 #3423
Contributor
There was a problem hiding this comment.
Hmm... I think it can be dealt at the same time as #3423 indeed?
Contributor
Author
There was a problem hiding this comment.
I changed the TODO wording.
maudetes
approved these changes
Sep 23, 2025
Contributor
maudetes
left a comment
maudetes
left a comment
There was a problem hiding this comment.
Thank you! I think the implementation is clean 👏
| if not TopicEditPermission(topic).can(): | ||
| apiv2.abort(403, "Forbidden") | ||
|
|
||
| # TODO: should we ignore activity creation here? |
Contributor
There was a problem hiding this comment.
Hmm... I think it can be dealt at the same time as #3423 indeed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
TopicRelatedActivityactivities forTopicElement:topic:element:createdtopic:element:deletedtopic:element:updatedIt supports changed field names in
changes[]onupdated.Related ecolabdata/ecospheres#601