fix: activities on private object not visible by owner#3567
Merged
ThibaudDauce merged 3 commits intomainfrom Dec 18, 2025
Merged
fix: activities on private object not visible by owner#3567ThibaudDauce merged 3 commits intomainfrom
ThibaudDauce merged 3 commits intomainfrom
Conversation
453aae9 to
915f81c
Compare
915f81c to
0817897
Compare
abulte
approved these changes
Dec 10, 2025
maudetes
approved these changes
Dec 12, 2025
Contributor
maudetes
left a comment
There was a problem hiding this comment.
Thank you for taking a go a it!
I think the existing activity logic filtering quite terrible 😢, but it should probably be investigated in a different iteration
Comment on lines
+124
to
+125
| if not getattr(self, "private", False): | ||
| return True |
Contributor
There was a problem hiding this comment.
I think it may be confusing with the is_visible computed properties that exist on multiple objects and that also takes other properties into account (deleted, archived, etc.), not behaving the same as this.
nicolaskempf57
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.