fix(harvest): invalid remote URL on record identifiers with "urn:uuid" codespace#3724
Draft
streino wants to merge 1 commit intoopendatateam:mainfrom
Draft
fix(harvest): invalid remote URL on record identifiers with "urn:uuid" codespace#3724streino wants to merge 1 commit intoopendatateam:mainfrom
streino wants to merge 1 commit intoopendatateam:mainfrom
Conversation
Contributor
Author
|
@maudetes I'd like your input before polishing the PR 🙏 Doesn't feel too good to handle a corner case, but I don't see any practical/robust way to handle all URN namespaces. I'd say "urn:uuid" is standard enough to warrant an extra Note that there's nothing GeoNetwork specific here: other software, or even GeoNetwork users designing their own record templates, can legitimately use codespaces in ISO-19115-3, and since IDs are often UUIDs, that makes "urn:uuid" one of the most likely candidates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ecolabdata/ecospheres#1019