fix: prevent 'null' display when instructor family_name is missing#4711
Open
rjv31 wants to merge 1 commit intoopenedx:masterfrom
Open
fix: prevent 'null' display when instructor family_name is missing#4711rjv31 wants to merge 1 commit intoopenedx:masterfrom
rjv31 wants to merge 1 commit intoopenedx:masterfrom
Conversation
rjv31
force-pushed
the
handle-missing-family-name-in-instructor-profile
branch
2 times, most recently
from
807dc00 to
c0e9734
Compare
rjv31
force-pushed
the
handle-missing-family-name-in-instructor-profile
branch
from
c0e9734 to
cc1e92c
Compare
ankit-sonata
suggested changes
Apr 10, 2026
| ) | ||
|
|
||
| def _get_node_data(self, person): | ||
| full_name = " ".join(filter(None, [person.given_name, person.family_name])) |
There was a problem hiding this comment.
This has two issues:
It silently drops the salutation field — if a person has salutation="Dr.", given_name="Jane", family_name="Smith", the model's full_name returns "Dr. Jane Smith", but this code would send "Jane Smith" to the marketing site.
It's redundant — person.full_name already handles None family_name correctly, so the fix doesn't actually change the behavior for the stated bug scenario (null family_name).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Instructor profiles display "null" when family_name is missing.
2U Ticket
https://2u-internal.atlassian.net/browse/CATALOG-87
Root Cause
The marketing site integration was using full_name directly, which could include null values.
Fix
Testing