Skip to content

fix: Removed DEFAULT_FILE_STORAGE and STATICFILES_STORAGES #2917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jawad-khan wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −19
Open

fix: Removed DEFAULT_FILE_STORAGE and STATICFILES_STORAGES #2917

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
440e212
fix: removed depricated storage vars
jawad-khan Dec 5, 2025
2d06b08
fix: fixed inline comment
jawad-khan Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions credentials/settings/devstack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,6 @@
EMAIL_BACKEND = "django.core.mail.backends.filebased.EmailBackend"
EMAIL_FILE_PATH = "/tmp/credentials-emails"

defaultfile_storage = os.environ.get("DEFAULT_FILE_STORAGE")

if defaultfile_storage:
STORAGES["default"]["BACKEND"] = defaultfile_storage

staticfiles_storage = os.environ.get("STATICFILES_STORAGE")

if staticfiles_storage:
STORAGES["staticfiles"]["BACKEND"] = staticfiles_storage

MEDIA_URL = os.environ.get("MEDIA_URL", "/media/")
STATIC_URL = os.environ.get("STATIC_URL", "/static/")

Expand Down
10 changes: 1 addition & 9 deletions credentials/settings/production.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,19 +45,11 @@
vars().update(config_from_yaml)

FILE_STORAGE_BACKEND = config_from_yaml.get("FILE_STORAGE_BACKEND", {})
default_backend = FILE_STORAGE_BACKEND.pop("DEFAULT_FILE_STORAGE", None)
Copy link
Copy Markdown
Contributor

@awais786 awais786 Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without STORAGES dict inside prod yaml we cant make these changes. It will break production

static_backend = FILE_STORAGE_BACKEND.pop("STATICFILES_STORAGE", None)

# Load the files storage backend settings for django storages
# In django==4.2.24 following line sets the DEFAULT_FILE_STORAGE and other AWS variables as per YAML.
# In django==4.2.24 following line sets AWS variables as per YAML.
Copy link

Copilot AI Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment references django==4.2.24, but requirements/django.txt indicates the project is using Django 5.2.7. The comment should be updated to reflect the actual Django version being used.

Suggested change
# In django==4.2.24 following line sets AWS variables as per YAML.
# In django==5.2.7 the following line sets AWS variables as per YAML.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor

@awais786 awais786 Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the inline comment.

vars().update(FILE_STORAGE_BACKEND)

if default_backend:
STORAGES["default"]["BACKEND"] = default_backend

if static_backend:
STORAGES["staticfiles"]["BACKEND"] = static_backend

# make sure this happens after the configuration file overrides so format string can be overridden
LOGGING = get_logger_config(format_string=LOGGING_FORMAT_STRING)

Expand Down