chore: add build:ci smoke test to verify webpack build#836
Merged
arbrandes merged 2 commits intoopenedx:frontend-basefrom Apr 23, 2026
Merged
chore: add build:ci smoke test to verify webpack build#836arbrandes merged 2 commits intoopenedx:frontend-basefrom
arbrandes merged 2 commits intoopenedx:frontend-basefrom
Conversation
arbrandes
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## frontend-base #836 +/- ##
================================================
Coverage ? 90.37%
================================================
Files ? 152
Lines ? 1288
Branches ? 272
================================================
Hits ? 1164
Misses ? 119
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adds an npm run build:ci script that exercises the real app graph through webpack, and wires it into the CI workflow after the existing build step. Co-Authored-By: Claude <noreply@anthropic.com>
Ports the CertificateBanner portion of 5e69cf8 (openedx#813). The ResumeButton changes from that commit are already covered by 4a75852. Co-Authored-By: Claude <noreply@anthropic.com>
brian-smith-tcril
approved these changes
Apr 23, 2026
| <> | ||
| {' '} | ||
| <Hyperlink isInline destination={certificate.certPreviewUrl}> | ||
| <Hyperlink isInline destination={baseAppUrl(certificate.certPreviewUrl)}> |
Contributor
There was a problem hiding this comment.
Wasn't sure where this change was coming from, looks like it landed in master with #813
Contributor
Author
There was a problem hiding this comment.
Yeah, I snuck it in, sorry! 😅
|
🎉 This PR is included in version 1.0.0-alpha.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Apps are distributed build-less, so
npm run buildonly compiles the librarydist/viatscand nothing in CI verifies that the app can actually be webpack-bundled as a deployable site. This PR adds annpm run build:ciscript that exercises the real app graph through webpack, and wires it into the CI workflow after the existing build step.Refs openedx/frontend-base#124.
Verifying the check
Introduce a typo in an import somewhere in
src/that is reached from the app's route/component graph (for example, rename a file import to a path that doesn't exist).npm run buildstill passes, butnpm run build:cifails with a module resolution error. Revert the typo and the build goes green again.LLM usage notice
Built with assistance from Claude.