Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ jobs:
- name: Build
run: npm run build

- name: Build (CI)
run: npm run build:ci

- name: Run Coverage
uses: codecov/codecov-action@v5
with:
Expand Down
3 changes: 3 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,9 @@ build:
done' sh {} +
tsc-alias -p tsconfig.build.json

build-ci:
SITE_CONFIG_PATH=site.config.ci.tsx openedx build

i18n.extract:
# Pulling display strings from .jsx files into .json files...
npm run-script i18n_extract
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
},
"scripts": {
"build": "make build",
"build:ci": "make build-ci",
"build:packages": "make build-packages",
"clean": "make clean",
"clean:packages": "make clean-packages",
Expand Down
24 changes: 24 additions & 0 deletions site.config.ci.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { EnvironmentTypes, SiteConfig, footerApp, headerApp, shellApp } from '@openedx/frontend-base';

import { learnerDashboardApp } from './src';

import '@openedx/frontend-base/shell/style';

const siteConfig: SiteConfig = {
siteId: 'learner-dashboard-ci',
siteName: 'Learner Dashboard CI',
baseUrl: 'http://apps.local.openedx.io',
lmsBaseUrl: 'http://local.openedx.io',
loginUrl: 'http://local.openedx.io/login',
logoutUrl: 'http://local.openedx.io/logout',

environment: EnvironmentTypes.PRODUCTION,
apps: [
shellApp,
headerApp,
footerApp,
learnerDashboardApp
],
};

export default siteConfig;
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export const CertificateBanner = ({ cardId }) => {
{certificate.certPreviewUrl && (
<>
{' '}
<Hyperlink isInline destination={certificate.certPreviewUrl}>
<Hyperlink isInline destination={baseAppUrl(certificate.certPreviewUrl)}>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wasn't sure where this change was coming from, looks like it landed in master with #813

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I snuck it in, sorry! 😅

{formatMessage(messages.viewCertificate)}
</Hyperlink>
</>
Expand Down
Loading