fix: let composing site own shell and brand CSS#835
Merged
arbrandes merged 2 commits intoopenedx:frontend-basefrom Apr 22, 2026
Merged
fix: let composing site own shell and brand CSS#835arbrandes merged 2 commits intoopenedx:frontend-basefrom
arbrandes merged 2 commits intoopenedx:frontend-basefrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## frontend-base #835 +/- ##
================================================
Coverage ? 90.37%
================================================
Files ? 152
Lines ? 1288
Branches ? 267
================================================
Hits ? 1164
Misses ? 119
Partials ? 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
arbrandes
changed the title
The shell stylesheet moved from a SCSS file to a JS manifest at @openedx/frontend-base/shell/style. Imports it directly from site.config.dev.tsx and drops the now-redundant site.scss. Removes the ./app.scss subpath export and drops @edx/brand since the dev harness runs unbranded. See openedx/frontend-base#232. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
brian-smith-tcril
approved these changes
Apr 22, 2026
|
🎉 This PR is included in version 1.0.0-alpha.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stops the app from re-bundling the shell stylesheet so lazy-loaded chunks no longer re-declare Paragon's
:rootcustom properties and clobber the composing site's brand tokens at runtime. The composing site becomes the single owner of shell, Paragon, and brand CSS.The dev harness now loads the shell styles via the new JS manifest at
@openedx/frontend-base/shell/style, imported directly fromsite.config.dev.tsx. The./app.scsssubpath export is removed, and@edx/brandis dropped since the dev harness runs unbranded. App-scoped class rules continue to load per-chunk viasrc/style.scss(renamed fromsrc/app.scss), imported fromMain.jsx.Mirrors the fix landed in
frontend-app-authnfor the same migration. See openedx/frontend-base#232 for the underlying rationale.LLM usage notice
Built with assistance from Claude models (mostly Opus 4.6).