Add and order new env vars to support backup on s3-compatible provider#1044
Merged
dacook merged 2 commits intoopenfoodfoundation:masterfrom Mar 10, 2026
Conversation
pacodelaluna
commented
Mar 4, 2026
pacodelaluna
commented
Mar 5, 2026
Contributor
Author
pacodelaluna
left a comment
pacodelaluna
left a comment
There was a problem hiding this comment.
I have anticipated a bit the backup setup refactoring, but I think it is clearer this way. The old configuration will still work even if the comments may be misleading. But this way, new backup configurations will follow the new pattern directly. Tell me if any issue with this.
dacook
approved these changes
Mar 10, 2026
github-project-automation
Bot
moved this from Code review 🔎
to Done
in OFN Delivery board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The objective is to support the new var envs required for backups on S3-compatible provider.
It is related to these PRs: