Enhance asset precompilation reliability with async execution#1048
Merged
mkllnk merged 1 commit intoopenfoodfoundation:masterfrom Mar 19, 2026
Conversation
dacook
approved these changes
Mar 18, 2026
mkllnk
approved these changes
Mar 19, 2026
Member
mkllnk
left a comment
mkllnk
left a comment
There was a problem hiding this comment.
Nice. I didn't know about this feature.
github-project-automation
Bot
moved this from Code review 🔎
to Done
in OFN Delivery board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1047
Summary
Improve reliability of asset precompilation during deployment by running the task asynchronously and monitoring it with controlled polling.
Changes
async: 1800to allow the asset precompilation task to run in the background with a maximum timeout of 30 minutes.poll: 10to check task status every 10 seconds while waiting for completion.Reason
Asset precompilation can take significant time and may cause deployment failures if executed synchronously. Running it asynchronously prevents blocking the playbook, while polling ensures the task is still tracked and completed reliably without overwhelming the server.
Impact
Testing