Add S3_REGION management in env template#1050
Merged
mkllnk merged 1 commit intoopenfoodfoundation:masterfrom Apr 2, 2026
Merged
Add S3_REGION management in env template#1050mkllnk merged 1 commit intoopenfoodfoundation:masterfrom
mkllnk merged 1 commit intoopenfoodfoundation:masterfrom
Conversation
4 tasks
pacodelaluna
force-pushed
the
add-s3-region-management-in-env-template
branch
from
32407a1 to
9bd7244
Compare
mkllnk
approved these changes
Apr 2, 2026
github-project-automation
Bot
moved this from All the things 💤
to Done
in OFN Delivery board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am not sure why, but the
S3_REGIONenv var was not handled by theenvtemplate. It was not an issue for existing configurations as there was a fallback for regions in storage.yml configuration. We should keep an eye on DB2Fog who was handling the region on its own, but it should be fine.Weirdly, I missed it while working on new S3-compatible setup... I have added the
S3_REGIONvar into theenvfiles, but as I thought the env var was already handled, I didn't ask to handle it. So it was only affecting the servers who have got new provisioning. I guess it was the case for theFR staginginstance.