Skip to content

feat(desktop): OS trust store and mTLS client certs for native HTTP #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giswqs merged 5 commits into from
Jul 14, 2026
Merged

feat(desktop): OS trust store and mTLS client certs for native HTTP #1225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
00a1429
feat(desktop): OS trust store and mTLS client certs for native HTTP
giswqs Jul 13, 2026
4b672b1
perf(desktop): cache the guarded HTTP client; error on stray mTLS pas…
giswqs Jul 13, 2026
ec6877a
fix(desktop): treat an empty mTLS passphrase as unset
giswqs Jul 13, 2026
d56b453
fix(desktop): treat empty cert paths as unset; error on non-UTF-8 pas…
giswqs Jul 13, 2026
aebc400
Merge branch 'main' into fix/issue-1220-native-http-mtls
giswqs Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 152 additions & 2 deletions apps/geolibre-desktop/src-tauri/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 4 additions & 1 deletion apps/geolibre-desktop/src-tauri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ tauri-plugin-opener = "2"
tauri-plugin-persisted-scope = "2"
duckdb = { version = "1.10504.0", features = ["bundled", "parquet"], optional = true }
chrono = { version = "0.4", default-features = false, features = ["std"] }
reqwest = { version = "0.12", default-features = false, features = ["blocking", "rustls-tls"] }
# rustls-tls stays the default backend for every request. rustls-tls-native-roots
# also trusts the OS/system certificate store (enterprise CAs), and native-tls is
# used only on the opt-in mTLS path for PKCS#12 client certificates (issue #1220).
reqwest = { version = "0.12", default-features = false, features = ["blocking", "rustls-tls", "rustls-tls-native-roots", "native-tls"] }
Comment on lines +42 to +45

@github-actions github-actions Bot Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quality (low-medium confidence, already flagged by the author in the PR description): native-tls and rustls-tls-native-roots are enabled unconditionally, so every desktop build — including Linux, where native-tls pulls in openssl/openssl-sys and links libssl — now carries this dependency even for the overwhelming majority of users who will never set GEOLIBRE_HTTP_CLIENT_CERT_PASSWORD to use a PKCS#12 identity. That's a real increase in build complexity (system OpenSSL dependency on Linux) and attack surface (an extra TLS stack) for a feature most installs won't use. Worth a deliberate call on whether to gate native-tls behind a Cargo feature flag (off by default) or accept the always-on cost, rather than defaulting it on silently.

flate2 = "1"
tar = "0.4"
zip = { version = "6", default-features = false, features = ["deflate"] }
Expand Down
Loading
Loading