fix(measure): show a real total in the Measure panel - #1465
Merged
Conversation
The Measure panel's "Total Distance" / "Total Area" readout dropped to 0.00 the moment a measurement was completed, even though the result was listed right below it. The readout rendered only the in-progress drawing's value, and finishing a measurement re-arms the tool, which resets that value to zero. Fixed upstream in maplibre-gl-components 0.28.1 (opengeos/maplibre-gl-components#124): the readout now sums the completed measurements of the active mode plus the one being drawn, refreshes when a measurement is deleted, and stays on screen after Escape while measurements remain. The panel's unit selector also re-renders the saved measurements list in the new unit instead of leaving the previous unit's numbers. Fixes #1460
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe pull request updates ChangesDependency Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
🔍 PR preview
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1460
Problem
Controls -> Measure showed Total Distance / Total Area as
0.00no matter how much the user measured. The reporter's screenshot captures it exactly: a completed polygon of1324428.31 Square Kilometerssits in the results list while the readout above reads0.00.Root cause
Upstream, in
maplibre-gl-components'MeasureControl. The readout rendered onlystate.currentValue(the drawing in progress). Finishing a measurement re-arms the tool for the next one, and re-arming resetscurrentValueto zero, so the number labelled "Total" collapsed to0.00the instant a measurement completed.Fix
Bumps
maplibre-gl-componentsto 0.28.1 (opengeos/maplibre-gl-components#124), where the readout now:Clear Allstill hides it.No GeoLibre-side wiring changes were needed.
mainalready tracked^0.28.0, so this is the patch bump plus the lockfile.Verification
Driven in a browser against the published 0.28.1, in light and dark themes:
4300.03 Kilometers, matching the list entryGate:
npm run buildclean,npm run test:frontend3951 passing,npm run test:workerclean,pre-commit run --files <changed>passing. Upstream: 247 tests passing (7 newMeasureControlcases), lint and build clean, CodeRabbit approved.Summary by CodeRabbit