Skip to content

Expose layer groups to external plugins - #1467

Merged
giswqs merged 1 commit into
mainfrom
feat/external-plugin-layer-groups
Jul 27, 2026
Merged

Expose layer groups to external plugins#1467
giswqs merged 1 commit into
mainfrom
feat/external-plugin-layer-groups

Conversation

@giswqs

@giswqs giswqs commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

  • expose host layer-group creation and removal through the external plugin API
  • preserve requested group IDs when external native layers are registered or updated
  • add coverage for external native layer group assignment

Testing

  • npm run lint
  • npm run build -w geolibre-desktop
  • npm test
  • pre-commit run --all-files

Summary by CodeRabbit

  • New Features
    • Plugins can now create and remove layer groups.
    • External layers can be assigned to existing layer groups.
    • Layer group assignments are preserved when external layer details are updated.

Copilot AI review requested due to automatic review settings July 27, 2026 13:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d570a341-409c-4108-a007-0265495e3e6e

📥 Commits

Reviewing files that changed from the base of the PR and between de6a423 and 17d82b5.

📒 Files selected for processing (4)
  • apps/geolibre-desktop/src/hooks/usePlugins.ts
  • apps/geolibre-desktop/src/lib/external-native-layer.ts
  • packages/plugins/src/types.ts
  • tests/external-native-layer.test.ts

📝 Walkthrough

Walkthrough

Plugin APIs now support layer-group creation and removal, while external native layer registrations can assign layers to groups. Existing group assignments persist when registrations are updated without a new group id, with regression coverage added.

Changes

Plugin layer-group support

Layer / File(s) Summary
Layer-group API contracts and wiring
packages/plugins/src/types.ts, apps/geolibre-desktop/src/hooks/usePlugins.ts
Plugin types declare optional group registration and management methods, which are wired to the application store.
External layer group propagation
apps/geolibre-desktop/src/lib/external-native-layer.ts, tests/external-native-layer.test.ts
External native layers apply registration group ids and preserve existing group ids during updates, with test coverage for both behaviors.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: copilot

Poem

I’m a rabbit with layers tucked neat,
Groups hop into the plugin’s seat.
Old group paths stay in view,
New APIs guide the queue,
Carrots bloom where layers meet.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: exposing layer groups to external plugins.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/external-plugin-layer-groups

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@giswqs
giswqs merged commit 33488ca into main Jul 27, 2026
18 checks passed
@giswqs
giswqs deleted the feat/external-plugin-layer-groups branch July 27, 2026 14:01
@github-actions

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants