chore(deps): clear the four transitive advisories failing the audit gate - #1688
Conversation
The CI `audit` job (`npm audit --omit=dev --audit-level=high`) has been red on main since new advisories landed against four transitive dependencies of `@modelcontextprotocol/sdk`. `fast-uri` needed a package.json change, not just a lockfile refresh: the `overrides` entry pinned it to exactly `3.1.4`, which #1378 added as the fixed version for the *previous* fast-uri advisory. GHSA-7p8r-x3mc-p8w7 covers 3.0.0 - 3.1.4, so that pin was holding the vulnerable version in place. Moved it to `^3.1.5` so the next patch flows in on its own rather than needing this same fix again. Versions moved: - fast-uri 3.1.4 -> 3.1.5 (GHSA-7p8r-x3mc-p8w7, high) - ip-address 10.2.0 -> 10.4.0 (GHSA-mwp4-54f8-5fhr, GHSA-4xrf-jv44-h6hh, GHSA-22jq-vg5j-6vgg, high) - @hono/node-server 1.19.14 -> 2.0.12 (GHSA-frvp-7c67-39w9, moderate) - hono 4.12.28 -> 4.12.34 (GHSA-8j4g-w8fx-2239, moderate) The `@hono/node-server` major is the only one worth a second look. The SDK declares `^1.19.9 || ^2.0.5`, so 2.x is a range it supports, and 2.0.5 is the floor the advisory fixes at, so the 1.x line has no patched release to move to. `npm ls --omit=dev --all` reports no invalid tree entries. `npm audit --omit=dev` now reports 0 vulnerabilities. Build, frontend suite (4943 passing), and worker typecheck all pass.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe package configuration updates the ChangesDependency override
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
No inline comments needed — nothing in this diff rises to a reportable finding. Code reviewBugs: None. This is a lockfile/manifest-only dependency bump ( Security: The change is itself a security fix — it resolves four transitive advisories ( Performance: N/A — no runtime code touched. Quality: The CLAUDE.md: No violations. This falls under normal dependency-update conventions (Dependabot/CI audit gate); no lockfiles requiring special handling (e.g. |
There was a problem hiding this comment.
Pull request overview
Unblocks the CI audit gate by updating transitive dependencies (primarily via @modelcontextprotocol/sdk) to versions that clear newly published advisories, without changing application source code.
Changes:
- Updates the root
overridesforfast-urifrom a vulnerable pin (3.1.4) to a patch-range (^3.1.5) so future patches flow automatically. - Refreshes the lockfile to pick up fixed transitive versions (
fast-uri@3.1.5,ip-address@10.4.0,hono@4.12.34,@hono/node-server@2.0.12).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Adjusts fast-uri override to ^3.1.5 to avoid holding a vulnerable patch in place. |
| package-lock.json | Updates resolved transitive dependency versions to advisory-fixed releases (including @hono/node-server 2.x). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🔍 Cloudflare PR preview
|
🔍 GitHub Pages PR preview
|
Why
The CI
auditjob (npm audit --omit=dev --audit-level=high) is currently red onmain, not just on one PR. Four new advisories landed against transitive dependencies of@modelcontextprotocol/sdk. Every open PR inherits the failure, so this unblocks the branch generally.The part that was not just a lockfile refresh
npm audit fixcleared three of the four.fast-urineeded apackage.jsonchange: theoverridesentry pinned it to exactly3.1.4, which #1378 added as the fixed version for the previous fast-uri advisory. GHSA-7p8r-x3mc-p8w7 covers3.0.0 - 3.1.4, so that pin was actively holding the vulnerable version in place against the resolver.Moved it to
^3.1.5rather than re-pinning an exact version, so the next patch flows in on its own instead of needing this same manual fix a third time. That also matches the caret style of the other four overrides.Versions moved
fast-uriip-address@hono/node-serverhonoOn the
@hono/node-servermajorThis is the only bump worth a second look. It is not a forced incompatibility: the SDK declares
"@hono/node-server": "^1.19.9 || ^2.0.5", so 2.x is a range it explicitly supports, and>=2.0.5is the floor the advisory fixes at, so the 1.x line has no patched release to move to.npm ls --omit=dev --allreports no invalid tree entries.Verification
npm audit --omit=dev --audit-level=high(the exact CI command): 0 vulnerabilities, exit 0. Previously exit 1.npm audit --omit=devat all severities: 0 vulnerabilities.npm run build,npm run test:frontend(4943 passing, 1 skipped),npm run test:worker: all pass.pre-commiton the changed files: passes.No source changes, only
package.jsonandpackage-lock.json.Summary by CodeRabbit
fast-uripackage override to use a compatible 3.1.5-or-later version range.