-
-
Notifications
You must be signed in to change notification settings - Fork 567
fix(ci): opt in to fork PR checkout so Claude review stops failing #1715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security (medium confidence): The safety argument above (no
npm ci/build/test/lifecycle-script execution, no Bash tool) covers the classic "pwn request" path, but there's a second execution path it doesn't address: Claude Code's own hook mechanism. If the checked-out fork head (which is exactly what this opt-in now allows onto disk) contains a.claude/settings.jsonor.claude/settings.local.jsonwithPreToolUse/PostToolUsehooks matchingRead/Grep/Glob, those hooks run as shell commands automatically — hook execution isn't gated by--allowedTools, so excluding Bash from the agent's tool list doesn't stop it. A PR could add such a file in the very diff being reviewed and get arbitrary command execution in the runner during this step, even thoughGITHUB_TOKENitself is scrubbed from subprocess env.Worth confirming (and ideally noting in the comment here) that
claude-code-actioneither ignores repo-local hook config or runs Claude Code with an isolated settings scope when reviewing untrusted fork content — otherwise this residual vector isn't covered by the reasoning given.Also worth double-checking (lower confidence): that
allow-unsafe-pr-checkoutis genuinely a supported input on the pinnedactions/checkout@v7release. If the input name is off, GitHub Actions will typically just warn about an unrecognized input rather than fail the step, so the original checkout refusal would silently persist rather than being fixed — the PR's own verification notes it hasn't yet been confirmed against a fork PR run.