i18n(fa): Refine Persian translations for GIS terminology and UI read… - #1758
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Persian desktop localization catalog standardizes display-style terminology and clarifies export, import, selection, creation, discard, and failure messages across application features. ChangesPersian desktop localization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/geolibre-desktop/src/i18n/locales/fa.json`:
- Line 44: Normalize the user-facing labels in fa.json identified by the
exportLibrary entry and the additional listed locations by replacing every
doubled space with a single space, without changing the surrounding Persian text
or translation keys.
- Around line 1003-1005: Update the trackExported and exportFailed translations
to use the existing “رد” track terminology instead of “مسیر” route terminology,
while preserving their respective track-export success and failure meanings.
- Line 1456: Update the exporting translation value in fa.json by replacing the
misspelled Persian word گزفتن with گرفتن, while preserving the rest of the
message and interpolation placeholders unchanged.
- Line 4054: Update the Persian descriptions at both the visible entry and the
corresponding message around the second referenced location to explicitly state
that the YOLO model is created in ONNX format, replacing the ambiguous “ایجادشده
به ONNX” wording with the established equivalent of “ساختهشده در قالب ONNX”
while preserving the rest of each translation.
- Line 1097: Update the "exported" translation in the fa locale so “GeoTIFF” and
the Persian text are separated properly, and remove the space before the final
period while preserving the intended success message.
- Line 57: Update the Persian description value in the fa locale so the phrase
corresponding to “lightweight” uses an appropriate term such as “سبک,” while
preserving the meanings of “cloud-native” and “GIS platform” from the English
source; remove the incorrect “شیوهٔ نمایش” wording.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: d748d0d2-fdc8-4aed-be0b-23338a5057fc
📒 Files selected for processing (1)
apps/geolibre-desktop/src/i18n/locales/fa.json
Contributor
🔍 Cloudflare PR preview
|
Contributor
🔍 GitHub Pages PR preview
|
- Collapse doubled spaces in nine user-facing Persian labels (export library, export all, GPX/GeoJSON export, print layout description, atlas export failure, GeoParquet, HTML export) - about.description: translate "lightweight" as سبک instead of شیوهٔ نمایش (display style), which described GeoLibre as a display-style platform - gps.trackExported / gps.exportFailed: use the رد track terminology already used by trackLog, record, and trackLayerName, and keep the messages about exporting rather than creating a route - georeferencer.exported: separate GeoTIFF from the Persian text and drop the space before the period - printLayout.atlas.exporting: fix the گزفتن typo (گرفتن) - objectDetection description and chooseModel: state the ONNX format explicitly with خروجیگرفتهشده در قالب ONNX
giswqs
approved these changes
Aug 7, 2026
giswqs
left a comment
giswqs
left a comment
Member
There was a problem hiding this comment.
Thank you very much for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @QiushengWu,
As a native Persian speaker with a background in geospatial technology, I have reviewed the fa.json catalog to improve machine-translated phrases into standard GIS terminology and natural Persian UI phrasing.
Key improvements in this PR:
Verified with npm run typecheck and i18n tests.
Summary by CodeRabbit