fix(stac): label asset formats in search results - #1975
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (24)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe STAC API now detects Parquet display formats separately from visualizable formats. The STAC asset selector shows localized format labels and addability status. Fixtures and tests cover supported, Parquet, and unknown assets. ChangesSTAC asset labels
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change labels supported STAC asset formats and prevents unsupported or unknown formats from being added; no actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
apps/geolibre-desktop/src/components/layout/TopToolbar.tsxtypescript-eslint does not support TS 7.0. Oops! Something went wrong! :( ESLint: 10.8.1 Error: typescript-eslint does not support TS 7.0. packages/plugins/src/index.tsESLint skipped: the matched ESLint configuration already failed (config-incompatibility). packages/plugins/src/plugins/maplibre-stac.tsESLint skipped: the matched ESLint configuration already failed (config-incompatibility).
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
🔍 Cloudflare PR preview
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Code reviewBugs: None found. Security: None found. No new untrusted input handling — asset Performance: None found. The added logic is O(1) string/regex work per asset in an already-small results list. Quality:
CLAUDE.md:
Both inline comments were posted on |
🔍 GitHub Pages PR preview
Note GitHub Pages built this preview successfully, but its serving edge returned HTTP 403 when checked. The links may still be propagating. |
- Route asset format and addability labels through the STAC localization API and translate every shipped locale. - Centralize supported and display-only format detection so Parquet cannot drift from the shared resolver.
|
Good — Everything checks out: the format detection logic, exhaustive switch handling, translations across all 19 locales, and e2e/unit test coverage are all consistent and correct. I found no bugs, security issues, or CLAUDE.md violations worth flagging — only one very minor style nit not worth an inline comment (the new No inline comments were posted since no concrete issues were found. Code reviewBugs: None found. The new Security: None found. Asset titles/keys are rendered via Performance: None found. Changes are simple string/lookup logic with no added loops over large data. Quality: Minor/optional — CLAUDE.md: Translation keys were added consistently across all 19 locale files with matching key sets, and |
Summary
Testing
npx playwright test e2e/stac-api-panel.spec.tspre-commit run --files packages/plugins/src/plugins/maplibre-stac.ts e2e/stac-api-panel.spec.tsus-censuscollection in light and dark themesFixes #1971
Summary by CodeRabbit