Skip to content

fix(processing): let Whitebox Dissolve take a grouping field #1997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giswqs merged 4 commits into from
Aug 19, 2026
Merged

fix(processing): let Whitebox Dissolve take a grouping field #1997

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f931925
fix(processing): let Whitebox Dissolve take a grouping field
giswqs Aug 19, 2026
ca59dda
fix(processing): run Whitebox WASM tools off the main thread
giswqs Aug 19, 2026
72c4122
Address Claude review feedback
giswqs Aug 19, 2026
4d91e9c
Address Claude review feedback
giswqs Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/geolibre-desktop/src/components/processing/ProcessingDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,9 @@ function isSubsetUrlParameter(tool: WhiteboxTool, param: WhiteboxToolParameter):
// vector inputs (points_to_line's `line_field`/`sort_field`, and ~170 other
// tools), so the dialog can offer the selected layer's attribute names instead
// of asking the user to recall a column name (GeoLibre#1459). The kind check is
// what keeps a same-named *dataset* param out (join_tables' `primary_key_field`
// is a vector input): only a scalar string names a column.
// what keeps a same-named *dataset* param out (the catalog types
// classify_objects_svm's `class_field` as a LiDAR input): only a scalar string
// names a column.
function isFieldParameter(param: WhiteboxToolParameter): boolean {
return parameterKind(param) === "string" && isFieldParameterName(param.name);
}
Expand Down
9 changes: 6 additions & 3 deletions apps/geolibre-desktop/src/lib/whitebox-field-params.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ export const FIELD_PARAM_SUFFIX = /(^|_)(fields?|attributes?)$/i;
/**
* Whether a parameter name reads as an attribute-column name.
*
* Callers must also check the parameter is a scalar string: `join_tables`
* exposes `primary_key_field` as a *dataset* input, and a dataset parameter
* names a file, not a column.
* Callers must also check the parameter is a scalar string: the sidecar's
* catalog exposes `classify_objects_svm`'s `class_field` as a *dataset* input,
* and a dataset parameter names a file, not a column. (The WASM manifests used
* to mistype ~40 of these the same way, `dissolve_field` among them, until
* opengeos/whitebox-wasm#19 taught the manifest inference that a `*_field` name
* is a column; the sidecar catalog still carries a few.)
*
* @param name - The tool parameter's name.
* @returns `true` when the name ends in a field/attribute suffix.
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/processing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@turf/voronoi": "^7.4.0",
"dggal": "^0.0.6",
"fflate": "^0.8.3",
"geolibre-wasm": "^1.5.1",
"geolibre-wasm": "^1.5.2",
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"geotiff": "^3.0.5",
"onnxruntime-web": "1.27.0",
"s2js": "^1.44.0"
Expand Down
Loading