Skip to content

chore: bump version to 0.6.0 - #86

Merged
giswqs merged 1 commit into
mainfrom
chore/bump-version-0-6-0
Jun 1, 2026
Merged

chore: bump version to 0.6.0#86
giswqs merged 1 commit into
mainfrom
chore/bump-version-0-6-0

Conversation

@giswqs

@giswqs giswqs commented Jun 1, 2026

Copy link
Copy Markdown
Member

Summary

  • Bump version from 0.5.0 to 0.6.0 across the npm workspaces, the Tauri desktop crate, and the Python processing sidecar
  • Update docs (README, architecture, index, project-format) to reference 0.6.0

Test plan

  • pre-commit run --all-files passes (includes npm build)

Release version bump across the monorepo (npm workspaces, Tauri crate,
and Python sidecar) and update docs to reference 0.6.0.
Copilot AI review requested due to automatic review settings June 1, 2026 05:49
@giswqs
giswqs merged commit e5ce80b into main Jun 1, 2026
5 of 6 checks passed
@giswqs
giswqs deleted the chore/bump-version-0-6-0 branch June 1, 2026 05:52
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Netlify preview: https://pr-86--opengeos.netlify.app

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

from pydantic import BaseModel

app = FastAPI(title="GeoLibre Server", version="0.1.0")
app = FastAPI(title="GeoLibre Server", version="0.6.0")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FastAPI version string is a second source of truth that will silently drift again in future bumps. Consider reading it from the installed package metadata instead:

Suggested change
app = FastAPI(title="GeoLibre Server", version="0.6.0")
app = FastAPI(title="GeoLibre Server", version=importlib.metadata.version("geolibre-server"))

You'd also need import importlib.metadata at the top of the file.

Unrelated but now stale: the module docstring on line 4 still says "Future integrations (v0.5+)" and the /run handler (line 56) still carries # TODO(v0.5). Both milestones have now been released and superseded; the planned GDAL/GeoPandas integrations are unimplemented but the marker version is in the past. At minimum the references should be bumped to v0.7+ or the TODOs replaced with a tracked issue link.

Comment thread package-lock.json
"engines": {
"node": ">=18"
"node": ">=22"
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lockfile's embedded engines.node was bumped from >=18 to >=22 here, consistent with the current root package.json. However, the three CI workflows (release.yml:49, pages.yml:40, netlify-preview.yml:39) all use node-version: lts/* without a floor pin. lts/* resolves to whatever GitHub Actions considers the current LTS release; if it ever resolves to a version below 22 in a maintenance-LTS window, npm ci with engine-strict enabled would break the build silently. Pinning to node-version: '22' (or adding a .nvmrc) would eliminate the ambiguity.

@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Code review

Bugs

Finding File Confidence
PROJECT_VERSION = "0.1.0" in packages/core/src/types.ts:40 was not updated by this version bump. This constant is written into every .geolibre.json file at createEmptyProject() (line 30) and projectFromStore() (line 89). Every project saved with the 0.6.0 release will still be stamped "version": "0.1.0", making it impossible for future migration logic to distinguish files created by any 0.x release. sample-data/example.geolibre.json likewise still carries "version": "0.1.0". If the constant is intentionally a schema version (decoupled from app version), it should be renamed PROJECT_FORMAT_VERSION and the design documented explicitly. packages/core/src/types.ts:40 High

Quality / Maintainability

Finding File Confidence
FastAPI version= is a hardcoded literal that diverged from pyproject.toml (was 0.1.0 while pyproject was 0.5.0) and needed a non-sequential jump here. Using importlib.metadata.version("geolibre-server") would keep them in sync automatically. See inline comment. backend/.../main.py:18 High
Module docstring says "Future integrations (v0.5+)" and /run carries # TODO(v0.5) — both milestone references are now past-due. v0.5 was released and superseded without delivering GDAL/GeoPandas/DuckDB Spatial. See inline comment. backend/.../main.py:4,56 High
All three CI workflows (release.yml, pages.yml, netlify-preview.yml) use node-version: lts/* while package.json now requires >=22. The wildcard is unpinned; a maintenance-LTS window could resolve below 22 and break builds. See inline comment. .github/workflows/*.yml Medium
docs/project-format.md:9 still documents the version field as Format version (0.1.0). Internally consistent with PROJECT_VERSION not being bumped, but amplifies the ambiguity about whether the format version is intentionally decoupled from the app version. docs/project-format.md:9 Low

CLAUDE.md

No CLAUDE.md found in the repository; no project-specific guidelines to check against.


Most actionable finding: PROJECT_VERSION = "0.1.0" in packages/core/src/types.ts — not touched by this PR, so all 0.6.0-era project files will be stamped with the wrong version. All other findings are quality/maintainability concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants