Fix data loss scenario when applying a feature addition delta on a layer with attributes having valid default values set to apply on update#1661
Merged
Conversation
suricactus
reviewed
Jun 15, 2026
suricactus
reviewed
Jun 15, 2026
suricactus
left a comment
suricactus
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the nice issue report and the fix. Would you mind providing a test to ensure we never regress on this one?
nirvn
force-pushed
the
default_value_data_loss_fix
branch
from
bff1c68 to
c2d9379
Compare
Collaborator
|
@nirvn the tests are failing, but the their intention looks good! |
nirvn
force-pushed
the
default_value_data_loss_fix
branch
2 times, most recently
from
8685a04 to
f3dc6d5
Compare
suricactus
reviewed
Jun 16, 2026
nirvn
force-pushed
the
default_value_data_loss_fix
branch
from
ed1e298 to
7bb2470
Compare
…yer with attributes having valid default values set to apply on update
nirvn
force-pushed
the
default_value_data_loss_fix
branch
from
7bb2470 to
3c5f5dd
Compare
suricactus
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1660 (explanation and sample project to reproduce data loss included in that issue).
Test case incoming.