[EXCEL-MULTI-LOOKUP-2] feat: patch parameters#1533
Draft
kevinkim-ogp wants to merge 7 commits intofeat/multi-row-max-rowsfrom
Draft
[EXCEL-MULTI-LOOKUP-2] feat: patch parameters#1533kevinkim-ogp wants to merge 7 commits intofeat/multi-row-max-rowsfrom
kevinkim-ogp wants to merge 7 commits intofeat/multi-row-max-rowsfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label lfg to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
7 tasks
d6908e2 to
fab088c
Compare
d0b8fe0 to
c824943
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
Temporary
patchParametersfunctionIntroduces a temporary
patchParametersfunction that migrates legacylookupColumnandlookupValueparameters to the newfiltersarray format for Excel Get table row and Get multiple table rows actions during test execution.Hidden
filtersargument that supports multiple lookup conditionAdds the
multirow-multicolargument for filters to enable multiple lookup conditions. However, this is currently set tohiddenIf: { op: always_trueso that the input remains hidden and the parameters indataInare also hidden when checking the test step result.Hides hidden parameters in
Updates the FlowStepTestController to exclude hidden form fields when comparing current form values against the last test execution data, preventing false negatives in the test status check.
Tests
Backward compatibility: create a Pipe with Get table row, Get multiple table rows, and Update table row actions first before checking out to this branch, publish the Pipe.
Patching function
filtersparameter is created and an array of ONE object. This object should containlookupColumnandlookupValueand correspond to the originallookupColumnandlookupValueparametersfiltersparameter is created and an array of ONE object. This object should containlookupColumnandlookupValueand correspond to the originallookupColumnandlookupValueparametersfiltersparameter is created and an array of ONE object. This object should containlookupColumnandlookupValueand correspond to the originallookupColumnandlookupValueparameters