Skip to content

[EXCEL-MULTI-LOOKUP-2] feat: patch parameters#1533

Draft
kevinkim-ogp wants to merge 7 commits intofeat/multi-row-max-rowsfrom
excel-multi-lookup/add-new-parameters
Draft

[EXCEL-MULTI-LOOKUP-2] feat: patch parameters#1533
kevinkim-ogp wants to merge 7 commits intofeat/multi-row-max-rowsfrom
excel-multi-lookup/add-new-parameters

Conversation

@kevinkim-ogp
Copy link
Copy Markdown
Contributor

@kevinkim-ogp kevinkim-ogp commented Apr 8, 2026

Changes

Temporary patchParameters function

Introduces a temporary patchParameters function that migrates legacy lookupColumn and lookupValue parameters to the new filters array format for Excel Get table row and Get multiple table rows actions during test execution.

Hidden filters argument that supports multiple lookup condition

Adds the multirow-multicolargument for filters to enable multiple lookup conditions. However, this is currently set to hiddenIf: { op: always_trueso that the input remains hidden and the parameters in dataIn are also hidden when checking the test step result.

Hides hidden parameters in

Updates the FlowStepTestController to exclude hidden form fields when comparing current form values against the last test execution data, preventing false negatives in the test status check.

Tests

Backward compatibility: create a Pipe with Get table row, Get multiple table rows, and Update table row actions first before checking out to this branch, publish the Pipe.

  • Verify that the Get table row action still works properly
  • Verify that the Get table rows actions still work properly
  • Verify that the Update table row actions still work properly

Patching function

  • Verify that creating a new Get table row action still works as intended
    • Verify that the filters parameter is created and an array of ONE object. This object should contain lookupColumn and lookupValue and correspond to the original lookupColumn and lookupValue parameters
  • Verify that creating a new Get multiple table rows action still works as intended
    • Verify that the filters parameter is created and an array of ONE object. This object should contain lookupColumn and lookupValue and correspond to the original lookupColumn and lookupValue parameters
  • Verify that creating a new Update table row action still works as intended
    • Verify that the filters parameter is created and an array of ONE object. This object should contain lookupColumn and lookupValue and correspond to the original lookupColumn and lookupValue parameters
  • Verify that checking step on an existing Get table row action also patches the parameters
  • Verify that checking step on an existing Get multiple table rows action also patches the parameters
  • Verify that checking step on an existing Update table row action also patches the parameters

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label lfg to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kevinkim-ogp kevinkim-ogp changed the title feat: add new parameters for new actions [EXCEL-MULTI-LOOKUP-2] feat: patch parameters Apr 8, 2026
@kevinkim-ogp kevinkim-ogp force-pushed the feat/multi-row-max-rows branch from d6908e2 to fab088c Compare April 14, 2026 05:58
@kevinkim-ogp kevinkim-ogp force-pushed the excel-multi-lookup/add-new-parameters branch from d0b8fe0 to c824943 Compare April 14, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant