Skip to content

PLU-591: [show-multiple-rows-2]: modified step regex and add table variable marker#1537

Open
m0nggh wants to merge 1 commit intofeat/find-multiple-rows/table-var-format-utilityfrom
feat/find-multiple-rows/table-var-regex-marker
Open

PLU-591: [show-multiple-rows-2]: modified step regex and add table variable marker#1537
m0nggh wants to merge 1 commit intofeat/find-multiple-rows/table-var-format-utilityfrom
feat/find-multiple-rows/table-var-regex-marker

Conversation

@m0nggh
Copy link
Copy Markdown
Contributor

@m0nggh m0nggh commented Apr 10, 2026

TL;DR

Added support for hex-encoded modifiers in step variables to enable table column selection functionality.

What changed?

  • Extended the variable regex pattern to support optional hex-encoded modifiers in the format {{step.<uuid>.<path>|<hexModifier>}}
  • Added parsing logic to decode hex-encoded modifiers and extract table column selection information
  • Introduced TableVariableMarker interface to pass table data and selected column IDs to action preprocessors
  • Added error handling for invalid hex encoding with appropriate logging

How to test?

  1. Create a step variable with a hex-encoded table modifier: {{step.abc-123-def.data|7461626c653a636f6c31}}
  2. Verify the modifier is correctly decoded (hex example decodes to "table:col1")
  3. Test with FormSG table data to ensure JSON parsing works correctly
  4. Verify that invalid hex encoding falls back gracefully and logs warnings
  5. Confirm that variables without modifiers continue to work as before

Why make this change?

This enables dynamic table column selection in step variables, allowing users to specify which columns from table data should be processed by subsequent actions. The hex encoding approach keeps the variable syntax clean while supporting complex modifier parameters.

Copy link
Copy Markdown
Contributor Author

m0nggh commented Apr 10, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label lfg to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@m0nggh m0nggh changed the title modified step regex and add table variable marker PLU-591: [show-multiple-rows-2]: modified step regex and add table variable marker Apr 10, 2026
@m0nggh m0nggh marked this pull request as ready for review April 10, 2026 13:15
@m0nggh m0nggh requested a review from a team as a code owner April 10, 2026 13:15
@linear
Copy link
Copy Markdown

linear bot commented Apr 10, 2026

@m0nggh m0nggh force-pushed the feat/find-multiple-rows/table-var-format-utility branch from d45fcde to ed039e8 Compare April 10, 2026 13:53
@m0nggh m0nggh force-pushed the feat/find-multiple-rows/table-var-regex-marker branch 2 times, most recently from 1f9edd2 to df14166 Compare April 11, 2026 02:11
@m0nggh m0nggh force-pushed the feat/find-multiple-rows/table-var-format-utility branch from ed039e8 to 6cc7c10 Compare April 11, 2026 02:11
@m0nggh m0nggh force-pushed the feat/find-multiple-rows/table-var-format-utility branch from 6cc7c10 to 7e46416 Compare April 15, 2026 02:47
@m0nggh m0nggh force-pushed the feat/find-multiple-rows/table-var-regex-marker branch from df14166 to 62ac196 Compare April 15, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant