PLU-708 (chore): design improvements#1554
Open
kevinkim-ogp wants to merge 1 commit intofeat/max-files-multi-row-descriptionsfrom
Open
PLU-708 (chore): design improvements#1554kevinkim-ogp wants to merge 1 commit intofeat/max-files-multi-row-descriptionsfrom
kevinkim-ogp wants to merge 1 commit intofeat/max-files-multi-row-descriptionsfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
5 tasks
Comment on lines
+21
to
+24
| .regex(/^[a-zA-Z0-9\s]+$/, { | ||
| message: | ||
| 'Output name can only contain letters, numbers, and spaces', | ||
| }), |
There was a problem hiding this comment.
The regex /^[a-zA-Z0-9\s]+$/ uses \s which matches ANY whitespace character (spaces, tabs, newlines, carriage returns, etc.), not just spaces. Users could potentially input tabs or newlines in field names.
This will cause inconsistent behavior when converting back via key.replace(/_/g, ' ') in get-data-out-metadata.ts because:
- Tab gets transformed to
_during schema validation - But converts back to a space (not tab) in the metadata
Fix:
.regex(/^[a-zA-Z0-9 ]+$/, {
message:
'Output name can only contain letters, numbers, and spaces',
})Use a literal space character instead of \s.
Suggested change
| .regex(/^[a-zA-Z0-9\s]+$/, { | |
| message: | |
| 'Output name can only contain letters, numbers, and spaces', | |
| }), | |
| .regex(/^[a-zA-Z0-9 ]+$/, { | |
| message: | |
| 'Output name can only contain letters, numbers, and spaces', | |
| }), | |
Spotted by Graphite
Is this helpful? React 👍 or 👎 to let us know.
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Improved the process-image action with better field name handling and enhanced UI labels.
What changed?
getDataOutMetadatato convert it back to the original field name the user setHow to test?
Field names
Verify the fields are accepted and transformed correctly (spaces become underscores internally)
Max files
Sanity check