PLU-723 (fix): Pipe collaborators not added to new Tile created from action#1555
Open
kevinkim-ogp wants to merge 1 commit intodevelop-v2from
Open
PLU-723 (fix): Pipe collaborators not added to new Tile created from action#1555kevinkim-ogp wants to merge 1 commit intodevelop-v2from
kevinkim-ogp wants to merge 1 commit intodevelop-v2from
Conversation
Contributor
Author
How to use the Graphite Merge QueueAdd the label lfg to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TL;DR
Owners can create a new Tile from the 'Create row' action, but collaborators were not automatically added.
This is inconsistent with selecting an existing Tile, which correctly syncs collaborators.
What changed?
createTablemutation now accepts an optionalflowIdinput parameter.flowIdis provided,addFlowTableConnectionis called to sync Pipe collaborators (editors, viewers) to the newly created table with their corresponding roles.ControlledAutocompletecomponent now readsflowIdfromEditorContextand passes it through when creating a new table option inline, ensuring the flow association is preserved during table creation from the Pipe Editor.How to test?
Creating Tile from the _action
_First, create or open a Pipe that you OWN and has collaborators.
Then, delete the collaborators from that SAME Pipe.
Sanity check