Skip to content

Commit 25756dc

Browse files
committed
[java223] Log too verbose and not clear enough
Closes dalgwen#58 Signed-off-by: Gwendal Roulleau <gwendal.roulleau@gmail.com>
1 parent 3f0bf3b commit 25756dc

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

  • bundles/org.openhab.automation.java223/src/main/java/org/openhab/automation/java223/internal/codegeneration

bundles/org.openhab.automation.java223/src/main/java/org/openhab/automation/java223/internal/codegeneration/DependencyGenerator.java

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,11 @@ public synchronized void createCoreDependencies() {
143143
packagesSuccessfullyExported.stream().map(s -> s.replace("/", "."))
144144
.forEach(packagesNotFound::remove);
145145
for (String remainingPackage : packagesNotFound) {
146-
LOGGER.warn("Failed to found classes to export in package {}", remainingPackage);
146+
if (!remainingPackage.isBlank()) {
147+
LOGGER.warn(
148+
"Failed to find classes to export in one packages listed in the additionalBundles parameter : {}",
149+
remainingPackage);
150+
}
147151
}
148152
}
149153

@@ -160,7 +164,7 @@ public synchronized void createCoreDependencies() {
160164

161165
private static void copyExportedClassesByClassLoader(Set<String> classesToExtract, JarOutputStream target) {
162166
for (String classToExtract : classesToExtract) {
163-
if (classToExtract.isEmpty()) {
167+
if (classToExtract.isBlank()) {
164168
continue;
165169
}
166170
String path = classToExtract.replaceAll("\\.", "/") + ".class";
@@ -176,7 +180,8 @@ private static void copyExportedClassesByClassLoader(Set<String> classesToExtrac
176180
LOGGER.warn("InputStream {} from classpath is null", classToExtract);
177181
}
178182
} catch (IOException e) {
179-
LOGGER.warn("Failed to copy classes '{}' from classpath: {}", classToExtract, e.getMessage());
183+
LOGGER.warn("Failed to copy from classpath the classes listed in the additionalClasses parameter: '{}'. Error is: {}",
184+
classToExtract, e.getMessage());
180185
}
181186
}
182187
}

0 commit comments

Comments
 (0)