[sensibo] Fix initialization for half-included devices - #20169
Merged
Conversation
Signed-off-by: Arne Seime <arne.seime@gmail.com>
seime
force-pushed
the
sensibo_partial_setup
branch
from
February 1, 2026 08:57
0ad3a98 to
8be3d93
Compare
lsiepel
reviewed
Feb 1, 2026
|
|
||
| public Map<String, ModeCapabilityDTO> getRemoteCapabilities() { | ||
| return remoteCapabilities.modes; | ||
| return remoteCapabilities != null ? remoteCapabilities.modes : null; |
Contributor
There was a problem hiding this comment.
To prevent null issues, you could choose to add @nullable annotations or return an empty list. You might need to check how the logic handles those cases.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a NullPointerException that occurs when Sensibo devices are only partially set up or disconnected, which lack the remoteCapabilities field in the API response. The fix adds a null-safety check in the DTO getter method and improves test coverage to prevent this regression in the future.
Changes:
- Added null-safety check for
remoteCapabilitiesfield inPodDetailsDTO.getRemoteCapabilities() - Enhanced test suite with better async handling using Awaitility library
- Added comprehensive test data representing devices without
remoteCapabilities(partially configured/disconnected devices)
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
bundles/org.openhab.binding.sensibo/src/main/java/org/openhab/binding/sensibo/internal/dto/poddetails/PodDetailsDTO.java |
Added null check to prevent NPE when remoteCapabilities is absent from API response |
bundles/org.openhab.binding.sensibo/src/test/java/org/openhab/binding/sensibo/internal/handler/SensiboAccountHandlerTest.java |
Improved test implementation using Awaitility for async operations, removed unused test parameter, and added test case for issue #18018 |
bundles/org.openhab.binding.sensibo/src/test/resources/get_pods_response_partial_setup.json |
Added realistic test data with 4 devices including one without remoteCapabilities field to reproduce the bug scenario |
bundles/org.openhab.binding.sensibo/src/test/resources/logback-test.xml |
Added test logging configuration for debugging test execution |
bundles/org.openhab.binding.sensibo/pom.xml |
Added test dependencies for logback-classic and awaitility to support improved test implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Gentle ping @seime could you look at the open comments? |
lsiepel
added
the
awaiting feedback
Contributor
|
Gentle ping @seime we have about 4-5 weeks left before code freeze for the next stable release. Would be nice to have this added before. |
Signed-off-by: Arne Seime <arne.seime@gmail.com>
lsiepel
removed
the
awaiting feedback
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
May 19, 2026
* Fix openhab#18018 Signed-off-by: Arne Seime <arne.seime@gmail.com>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Jun 13, 2026
* Fix openhab#18018 Signed-off-by: Arne Seime <arne.seime@gmail.com>
darkscout
pushed a commit
to darkscout/openhab-addons
that referenced
this pull request
Jul 5, 2026
* Fix openhab#18018 Signed-off-by: Arne Seime <arne.seime@gmail.com>
olemr
pushed a commit
to olemr/openhab2-addons
that referenced
this pull request
Aug 8, 2026
* Fix openhab#18018 Signed-off-by: Arne Seime <arne.seime@gmail.com> Signed-off-by: olemr <olemr@olemr.com>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Aug 16, 2026
* Fix openhab#18018 Signed-off-by: Arne Seime <arne.seime@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #18018
Improve testcase.