Skip to content

[hue] Fix firmware availability issues - #20709

Merged
jlaur merged 7 commits into
openhab:mainfrom
andrewfg:hue-software-fix
May 16, 2026
Merged

[hue] Fix firmware availability issues#20709
jlaur merged 7 commits into
openhab:mainfrom
andrewfg:hue-software-fix

Conversation

@andrewfg

@andrewfg andrewfg commented May 12, 2026

Copy link
Copy Markdown
Contributor

Resolves #20702
Depends on #20707

Signed-off-by: Andrew Fiddian-Green software@whitebear.ch

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg andrewfg self-assigned this May 12, 2026
@andrewfg andrewfg added the bug An unexpected problem or unintended behavior of an add-on label May 12, 2026
@andrewfg
andrewfg requested review from Copilot and jlaur May 12, 2026 14:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Hue API v2 bridge firmware update availability signaling so the trigger channel matches the documented channel group and avoids repeated hourly trigger events.

Changes:

  • Prefix the update-ready trigger channel ID with the software channel group (software#update-ready).
  • Add a handler-side guard to only trigger the “update ready” event once per runtime.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
bundles/org.openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/HueBindingConstants.java Adjustes the update-ready channel ID to include the software group separator.
bundles/org.openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2BridgeHandler.java Prevents repeated triggering of the update-ready event by tracking whether a notification was already sent.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@andrewfg

This comment was marked as resolved.

andrewfg added 2 commits May 12, 2026 15:53
- bump thing upgrade instructions
- reset softwareUpdateReadyNotificationSent flag

Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>

@jlaur jlaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have not yet had time to test this, but did a quick review for now.

@andrewfg
andrewfg requested review from Copilot and jlaur May 12, 2026 22:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

bundles/org.openhab.binding.hue/src/main/java/org/openhab/binding/hue/internal/handler/Clip2BridgeHandler.java:1

  • softwareUpdateReadyNotificationSent is unintentionally reset to false when status == READY_TO_INSTALL and the notification was already sent. In that case, newSentFlagValue stays false and the assignment at the end clears the flag, causing the trigger to fire again on the next refresh. Fix by ensuring the “sent” flag remains true for as long as the status remains READY_TO_INSTALL (e.g., initialize newSentFlagValue from wasSentFlagValue, or explicitly set newSentFlagValue = wasSentFlagValue || status == READY_TO_INSTALL and only call triggerChannel on the transition from not-sent to sent).
/*

andrewfg and others added 2 commits May 12, 2026 23:40
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
@andrewfg
andrewfg requested a review from a team May 15, 2026 17:56

@jlaur jlaur left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and reviewed, LGTM.

@jlaur
jlaur merged commit d5ba6f9 into openhab:main May 16, 2026
2 checks passed
@jlaur jlaur added this to the 5.2 milestone May 16, 2026
@jlaur jlaur added the regression Regression that happened during the development of a release. Not shown on final release notes. label May 16, 2026
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 19, 2026
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Jun 13, 2026
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
darkscout pushed a commit to darkscout/openhab-addons that referenced this pull request Jul 5, 2026
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
olemr pushed a commit to olemr/openhab2-addons that referenced this pull request Aug 8, 2026
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: olemr <olemr@olemr.com>
cipianpascu pushed a commit to cipianpascu/openhab-addons that referenced this pull request Aug 16, 2026
Signed-off-by: Andrew Fiddian-Green <software@whitebear.ch>
Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[hue] Firmware availability issues

3 participants