[shelly] Minor tweak to Shelly v1 handler californium adaption - #20729
Merged
Conversation
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
This was referenced May 15, 2026
Contributor
|
Regression of #20704 |
lsiepel
added
the
regression
Contributor
Author
It's not really a regression, but if that helps with the formalities 😉 |
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
May 19, 2026
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Jun 13, 2026
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
darkscout
pushed a commit
to darkscout/openhab-addons
that referenced
this pull request
Jul 5, 2026
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com>
olemr
pushed a commit
to olemr/openhab2-addons
that referenced
this pull request
Aug 8, 2026
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com> Signed-off-by: olemr <olemr@olemr.com>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Aug 16, 2026
Signed-off-by: Ravi Nadahar <nadahar@rediffmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #20727 and this post, there was some doubt as to the correctness of #20704. I now believe that this was wrong, #20704 seems to be mostly correct.
I did this very minor tweak to make the code closer in behavior to what it originally was, and made a build that has been successfully tested by two different users that have such Shelly devices.
I therefore submit this PR to make the code 100% in line with the version they have tested, but I'm confident that the binding works also without this tweak, but the log might be slightly worse.