Skip to content
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
72 commits
Select commit Hold shift + click to select a range
86e9bf5
tweak default minimum dimming level
andrewfg Jun 26, 2026
5d6fbc6
fix for signe lamps
andrewfg Jun 26, 2026
d4aebc0
tweak precision
andrewfg Jun 26, 2026
698dc1a
add min dim level config param
andrewfg Jun 26, 2026
2daf740
self documenting minimum value
andrewfg Jun 26, 2026
7947690
add support for manual mirek schema
andrewfg Jun 26, 2026
9e39ca8
refine manual mirek stuff
andrewfg Jun 26, 2026
2664a45
shorten variable names
andrewfg Jun 26, 2026
660c091
fix log level
andrewfg Jun 26, 2026
b9a115e
oops
andrewfg Jun 26, 2026
a8a88d9
doc
andrewfg Jun 26, 2026
f0c24af
various
andrewfg Jun 28, 2026
ba8a444
fix build
andrewfg Jun 28, 2026
f7fbce4
refine 'setters' helpers
andrewfg Jun 29, 2026
9b4b7d2
various
andrewfg Jun 30, 2026
da15d4a
bug fixes
andrewfg Jun 30, 2026
3169984
tweaks
andrewfg Jun 30, 2026
634e0bc
various
andrewfg Jul 1, 2026
962d2b7
cosmetic
andrewfg Jul 1, 2026
1e208e7
various
andrewfg Jul 1, 2026
2987514
refactor
andrewfg Jul 2, 2026
86c02de
reduce deltas
andrewfg Jul 3, 2026
5a8723b
adopt some copilot suggestions
andrewfg Jul 3, 2026
12c81e2
extend lk wiser fix to tradfri bulbs too
andrewfg Jul 4, 2026
f2f1be5
javadoc fixes
andrewfg Jul 5, 2026
2a71439
various
andrewfg Jul 5, 2026
f230521
apply work around to bridge home
andrewfg Jul 5, 2026
556623c
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 5, 2026
b968318
spotless on pom
andrewfg Jul 5, 2026
c208472
unfix pom
andrewfg Jul 5, 2026
583cf13
tweak java doc and variable name
andrewfg Jul 5, 2026
586232b
work-around check children recursively
andrewfg Jul 6, 2026
060efbf
javadoc
andrewfg Jul 6, 2026
0029adf
remove duplicate code
andrewfg Jul 6, 2026
58c0580
adopt copilot suggestions
andrewfg Jul 6, 2026
d31aebe
revert mess caused by copilot wrong suggestion
andrewfg Jul 6, 2026
ec566b1
Merge branch 'openhab:main' into hue-min-dim-level
andrewfg Jul 6, 2026
e68e3ef
use regex pattern for workaround check
andrewfg Jul 8, 2026
f49a26c
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 8, 2026
7de6c8f
fix pattern matcher
andrewfg Jul 8, 2026
ce878c3
remove annotation
andrewfg Jul 8, 2026
21ee86d
AI proof properties
andrewfg Jul 10, 2026
66bb5a5
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 10, 2026
67c3ae7
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 10, 2026
d315c7a
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 12, 2026
3687202
support dual mode lights
andrewfg Jul 12, 2026
e742242
tweaks
andrewfg Jul 12, 2026
1bda040
logic fixes
andrewfg Jul 12, 2026
25e8749
improve legacy work-around algorithm
andrewfg Jul 13, 2026
966a374
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 13, 2026
3bfd99a
copilot fixes
andrewfg Jul 13, 2026
8f276a7
bug fixes
andrewfg Jul 22, 2026
1dacc46
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 23, 2026
b7ee4a7
complete refactor of legacy bi-stable mode workaround
andrewfg Jul 23, 2026
e31e765
quality improvements
andrewfg Jul 24, 2026
2c5924c
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 24, 2026
28d04c0
various small issues
andrewfg Jul 24, 2026
9f444d7
jav doc
andrewfg Jul 24, 2026
6503ab2
fix loop back notify
andrewfg Jul 24, 2026
1ebf92e
improve color temperature command loop back
andrewfg Jul 24, 2026
b316310
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 24, 2026
53a820e
improve loop-back and logging
andrewfg Jul 25, 2026
d19e2db
Merge remote-tracking branch 'upstream/main' into hue-min-dim-level
andrewfg Jul 25, 2026
33a32e2
fix regression
andrewfg Jul 25, 2026
0585981
stop using minimum dimming level
andrewfg Aug 4, 2026
5bf1fff
revert Inc-/DecreaseType code to prior
andrewfg Aug 10, 2026
e554c4a
adopt AI and reviewer suggestions
andrewfg Aug 10, 2026
a112b65
bug fix
andrewfg Aug 10, 2026
a1bdb79
don't catch CriticalFieldMissingException
andrewfg Aug 10, 2026
388f53b
various
andrewfg Aug 11, 2026
2836660
adopt ai nit-picks
andrewfg Aug 11, 2026
4e83f09
fix hypothetical what if maybe on a blue moon issue
andrewfg Aug 11, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public class Dimming {
private @Nullable Double brightness;
private @Nullable @SerializedName("min_dim_level") Double minimumDimmingLevel;

public static final double DEFAULT_MINIMUM_DIMMIMG_LEVEL = 0.5f;
public static final double DEFAULT_MINIMUM_DIMMIMG_LEVEL = 0.39f;
Comment thread
andrewfg marked this conversation as resolved.
Outdated

/**
* @throws DTOPresentButEmptyException to indicate that the DTO is present but empty.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -438,6 +438,7 @@ public void handleCommand(ChannelUID channelUID, Command commandParam) {
putResource = Setters.setDimming(putResource, brightnessCommand, cache);
Double minDimLevel = Objects.nonNull(cache) ? cache.getMinimumDimmingLevel() : null;
minDimLevel = Objects.nonNull(minDimLevel) ? minDimLevel : Dimming.DEFAULT_MINIMUM_DIMMIMG_LEVEL;
minDimLevel = minDimLevel == 0.0 ? 0.01 : minDimLevel; // exact 0.0 must cause OFF (e.g. 'Signe')
command = OnOffType.from(brightnessCommand.doubleValue() >= minDimLevel);
}
// NB fall through for handling of switch related commands !!
Expand Down
Loading