[worxlandroid] Fix NumberFormatException when sending a Command to mode Channel - #21331
Merged
lsiepel merged 5 commits intoAug 14, 2026
Merged
Conversation
…de Channel Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes schedule mode command conversion for Worx Landroid mowers.
Changes:
- Passes raw schedule commands to channel-specific handling.
- Adds mode-to-protocol-code mapping.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
WorxLandroidMowerHandler.java |
Converts mode commands to mower codes. |
WorxLandroidModeCodes.java |
Defines Normal and Party mode codes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
I'd go for dropping backwards compatibility and have the more readable commands/enum values (update docs, add upgrade instruction). Also looks like Copilot found a real issue. |
This reverts commit dd4af78.
Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Contributor
Author
|
I applied the comments from Copilot review and added a hint to the docs. |
lsiepel
reviewed
Aug 14, 2026
Signed-off-by: lsiepel <leosiepel@gmail.com>
lsiepel
pushed a commit
that referenced
this pull request
Aug 14, 2026
…de Channel (#21331) * [worxlandroid] Fix NumberFormatException when sending a Command to mode Channel Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Aug 16, 2026
…de Channel (openhab#21331) * [worxlandroid] Fix NumberFormatException when sending a Command to mode Channel Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NumberFormatExceptionwhen sending a Command to mode ChannelA different solution might be adding command options to the channel-type like this:
Signed-off-by: Christoph Weitkamp github@christophweitkamp.de