[http] Fix test stability - #21392
Merged
Merged
Conversation
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the stability of the HTTP binding’s RateLimitedHttpClientTest by measuring rate-limit intervals using the timestamp captured immediately before each HTTP request is sent, instead of using a timestamp taken after the response returns (which can be skewed by response latency).
Changes:
- Capture a
requestTimejust before callingrequest.send()in the async callback. - Pass that timestamp into the
Responseobject instead of initializingtimeat construction time. - Update the
Responseconstructor/signature to accept the timestamp explicitly.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cipianpascu
pushed a commit
to cipianpascu/openhab-addons
that referenced
this pull request
Aug 16, 2026
Signed-off-by: Leo Siepel <leosiepel@gmail.com> Signed-off-by: Ciprian Pascu <contact@ciprianpascu.ro>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky RateLimitedHttpClientTest timing assertions by recording the request timestamp before sending the HTTP request. This prevents response latency from reducing the measured rate-limit interval below the configured delay.
Fixes #17385