[teslascope] Remove deprecated apiKey support - #21396
Conversation
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
wborn
left a comment
There was a problem hiding this comment.
This PR is being reviewed with AI first.
The PAT-only authentication changes look coherent, but one configuration-metadata inconsistency needs to be addressed before merge.
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
|
I guess htis would also require an upgrade notice in the distro repo |
Is this something I need to do? |
wborn
left a comment
There was a problem hiding this comment.
The previous configuration-metadata issue is fixed: apiKey has been removed from the account metadata, and personalAccessToken is now required and documented consistently.
No further issues were identified in the current code changes. The existing discussion about adding a 5.3 upgrade alert in openhab-distro remains valid and should be followed up separately.
This review was AI-assisted.
AI found no further blocking issues in the current changes.
lsiepel
left a comment
There was a problem hiding this comment.
Thanks, LGTM
This PR requires an update notices. It can be added here:
https://github.com/openhab/openhab-distro/blob/4d6ef89737dab07a0ee8566ce27ca895814ada2f/distributions/openhab/src/main/resources/bin/update.lst#L217 with a PR against the openhab-distro repository, just like any other.
Done |
The Teslascope service has deprecated the apikey method in favour of oauth and Personal Access Tokens (PATs).
Support for PATs was added on OH 5.2, and a warning was added to logs for users who are using ApiKeys to encourage then to nove to PATs.
The Teslascope maintainer intends to remove support for apiKeys at the end of 2026, which aligns nicely with the OH 5.3 release cycle, so this PR removes support for apikey and leaves only support for PATs.
This is a breaking change for anyone who has ignored the release notes for 5.2.