Skip to content

[teslascope] Remove deprecated apiKey support - #21396

Merged
lsiepel merged 4 commits into
openhab:mainfrom
psmedley:teslascope-apikey-remove
Aug 18, 2026
Merged

[teslascope] Remove deprecated apiKey support#21396
lsiepel merged 4 commits into
openhab:mainfrom
psmedley:teslascope-apikey-remove

Conversation

@psmedley

Copy link
Copy Markdown
Contributor

The Teslascope service has deprecated the apikey method in favour of oauth and Personal Access Tokens (PATs).
Support for PATs was added on OH 5.2, and a warning was added to logs for users who are using ApiKeys to encourage then to nove to PATs.

The Teslascope maintainer intends to remove support for apiKeys at the end of 2026, which aligns nicely with the OH 5.3 release cycle, so this PR removes support for apikey and leaves only support for PATs.

This is a breaking change for anyone who has ignored the release notes for 5.2.

Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
wborn
wborn previously requested changes Aug 15, 2026

@wborn wborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed with AI first.

The PAT-only authentication changes look coherent, but one configuration-metadata inconsistency needs to be addressed before merge.

Comment thread bundles/org.openhab.binding.teslascope/README.md
Signed-off-by: Paul Smedley <paul@smedley.id.au>
Signed-off-by: Paul Smedley <paul@smedley.id.au>
@lsiepel lsiepel added enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible labels Aug 15, 2026
@lsiepel

lsiepel commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

I guess htis would also require an upgrade notice in the distro repo

@psmedley

Copy link
Copy Markdown
Contributor Author

I guess htis would also require an upgrade notice in the distro repo

Is this something I need to do?

@wborn wborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous configuration-metadata issue is fixed: apiKey has been removed from the account metadata, and personalAccessToken is now required and documented consistently.

No further issues were identified in the current code changes. The existing discussion about adding a 5.3 upgrade alert in openhab-distro remains valid and should be followed up separately.

This review was AI-assisted.

@wborn
wborn dismissed their stale review August 17, 2026 13:30

AI found no further blocking issues in the current changes.

@lsiepel lsiepel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

This PR requires an update notices. It can be added here:
https://github.com/openhab/openhab-distro/blob/4d6ef89737dab07a0ee8566ce27ca895814ada2f/distributions/openhab/src/main/resources/bin/update.lst#L217 with a PR against the openhab-distro repository, just like any other.

@lsiepel
lsiepel merged commit 02d1a0b into openhab:main Aug 18, 2026
4 checks passed
@lsiepel lsiepel added this to the 5.3 milestone Aug 18, 2026
@lsiepel lsiepel changed the title [teslascope] remove deprecated apiKey support [teslascope] Remove deprecated apiKey support Aug 18, 2026
@psmedley
psmedley deleted the teslascope-apikey-remove branch August 18, 2026 07:25
@psmedley

Copy link
Copy Markdown
Contributor Author

This PR requires an update notices. It can be added here: https://github.com/openhab/openhab-distro/blob/4d6ef89737dab07a0ee8566ce27ca895814ada2f/distributions/openhab/src/main/resources/bin/update.lst#L217 with a PR against the openhab-distro repository, just like any other.

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants