Skip to content

[teslascope] Support basic FSD Stats - #21398

Merged
lsiepel merged 3 commits into
openhab:mainfrom
psmedley:teslascope-fsd-stats
Aug 17, 2026
Merged

[teslascope] Support basic FSD Stats#21398
lsiepel merged 3 commits into
openhab:mainfrom
psmedley:teslascope-fsd-stats

Conversation

@psmedley

Copy link
Copy Markdown
Contributor

Add basic support for some FSD stats:

  • distance travelled on FSD
  • distance travelled total
  • % of travel on FSD

Signed-off-by: Paul Smedley <paul@smedley.id.au>
wborn
wborn previously requested changes Aug 15, 2026

@wborn wborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed with AI first.

The new FSD values are wired through the API model and handler, and the version-3 migration for existing Things is present.

One functional issue needs to be addressed before merge: the new channel types are not referenced from the vehicle Thing type, so newly created vehicle Things would not contain these channels.

Please also update the binding README and regenerate the default i18n properties for the new channel metadata.

Signed-off-by: Paul Smedley <paul@smedley.id.au>
@lsiepel lsiepel added the enhancement An enhancement or new feature for an existing add-on label Aug 15, 2026

@wborn wborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The findings from the previous review have been addressed. One small documentation regression remains in the README; otherwise no further issues were found in the current changes.

This review was AI-assisted.

Comment thread bundles/org.openhab.binding.teslascope/README.md Outdated
@wborn
wborn dismissed their stale review August 17, 2026 12:29

Minor issue remaining

Signed-off-by: Paul Smedley <paul@smedley.id.au>

@lsiepel lsiepel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@lsiepel
lsiepel merged commit 831aa8d into openhab:main Aug 17, 2026
2 checks passed
@lsiepel lsiepel added this to the 5.3 milestone Aug 17, 2026
@psmedley
psmedley deleted the teslascope-fsd-stats branch August 18, 2026 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature for an existing add-on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants