[homie] Enable and fix tests - #21416
Merged
Merged
Conversation
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR re-enables previously disabled Homie integration tests and improves their determinism by removing timing/ordering assumptions around MQTT subscription setup and asynchronous channel-state delivery.
Changes:
- Re-enabled
retrieveOneAttribute,retrieveAttributes, andparseHomieTreetests and increased timeouts for MQTT message arrival under CI load. - Adjusted assertions to wait on observable outcomes (channel-state callbacks / asynchronously delivered state) rather than relying on method-entry timing.
- Improved test resource handling by reusing a shared scheduler and explicitly unsubscribing a temporary MQTT subscriber.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Contributor
Author
|
While working on these tests, codex found an issue in production code: #21417 |
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
wborn
reviewed
Aug 17, 2026
wborn
left a comment
Member
There was a problem hiding this comment.
This PR is initially reviewed with AI assistance.
The test synchronization and cleanup changes look good. The previously reported timing and subscription-ordering issues appear to be addressed, and no further functional issues were identified.
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failures were caused by timing and ordering assumptions in the tests, not in production code.
retrieveOneAttribute,retrieveAttributes, andparseHomieTree.PR was created with the assistence of codex. Manually reviewed and adapted where needed.
Fixes: #12667
Refs: #12829
Refs: #12812