[oppo] Add discrete thing types & other improvements by mlobstein · Pull Request #21445 · openhab/openhab-addons

mlobstein · 2026-08-21T04:56:46Z

This PR adds discrete thing types for each model. By doing so the available channels, remote button options, polling commands, etc. are tailored to the capabilities of each model. The original thing type id player remains as before but is now deprecated.

Additional fixes include:

The source channel on BDP-10x players using direct IP connections is now able to change the source.
Prevent source channel bouncing on BDP-10x and UDP-20x players after a command is received.
Direct IP connections on BDP-93/95 players now use the correct port number.

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

Copilot

Pull request overview

This PR enhances the Oppo binding by introducing discrete Thing types per player model so channel availability, remote-button options, and polling behavior can be tailored to each device’s capabilities, while keeping the existing generic player Thing type available (now deprecated).

Changes:

Added dedicated Thing type definitions for BDP-83, BDP-93/95, BDP-103/103D, BDP-105/105D, UDP-203, and UDP-205.
Refactored handler/discovery logic to support the new Thing types (model inference, model-specific query command sets, improved source handling/debouncing, updated discovery classification).
Updated binding documentation and i18n resources to reflect the new Thing types and options.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/thing/udp205.xml	Adds a UDP-205-specific Thing type with a tailored channel list.
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/thing/udp203.xml	Adds a UDP-203-specific Thing type and model-specific remote button channel-type definition.
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/thing/bdp93.xml	Adds a BDP-93/95-specific Thing type with a tailored channel list.
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/thing/bdp83.xml	Adds a BDP-83-specific Thing type and model-specific remote button channel-type definition.
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/thing/bdp105.xml	Adds a BDP-105/105D-specific Thing type referencing model-appropriate remote button options.
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/thing/bdp103.xml	Adds a BDP-103/103D-specific Thing type and model-specific remote button channel-type definition.
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/thing/channels.xml	Marks the generic `player` Thing type as deprecated (comment) and splits the legacy model option into 83 vs 93/95.
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/i18n/oppo.properties	Adds labels/descriptions for the new Thing types, new config keys, and remote-button option i18n.
bundles/org.openhab.binding.oppo/src/main/resources/OH-INF/config/config.xml	Introduces a reusable config description (`thing-type:oppo:oppoconfig`) referenced by the new Thing types.
bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/OppoHandlerFactory.java	Extends supported Thing types to include the new per-model ThingTypeUIDs.
bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/OppoBindingConstants.java	Adds ThingTypeUID constants for the new Thing types and a new MODEL93 constant.
bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java	Infers model from Thing type (non-legacy), uses model-specific query sets, improves source handling for BDP direct IP and source “bounce” prevention.
bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/discovery/OppoDiscoveryService.java	Updates discovery to produce per-model Thing types and improves related documentation/comments.
bundles/org.openhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/communication/OppoCommand.java	Splits polling query command sets by model family (83/9x vs 10x vs 20x).
bundles/org.openhab.binding.oppo/README.md	Documents new Thing types, updated configuration guidance, and refreshed remote-button notes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

jlaur

Thanks, this looks really nice! I had a quick look and found only some nitpicking in addition to Copilot's findings. Looking forward to try it out in the weekend. 🙂

jlaur · 2026-08-21T21:53:13Z

+            }
+            model = config.model;
+        } else {
+            model = Integer.parseInt(thing.getThingTypeUID().getAsString().replaceAll("[^\\d.]", ""));


Although not as clever, perhaps it would be more robust (and faster) to provide explicit mapping from ThingTypeUID to model?

What would you suggest? A thing property (modelId) perhaps? Otherwise an if-else block is all that comes to mind.

How about adding this to OppoBindingConstants right after the model constants:

public static final Map<ThingTypeUID, Integer> THING_TYPE_TO_MODEL = Map.of( // THING_TYPE_BDP83, MODEL83, // THING_TYPE_BDP93, MODEL93, // THING_TYPE_BDP103, MODEL103, // THING_TYPE_BDP105, MODEL105, // THING_TYPE_UDP203, MODEL203, // THING_TYPE_UDP205, MODEL205);

and then something like this to look it up:

model = THING_TYPE_TO_MODEL.getOrDefault(thing.getThingTypeUID(), 0);

?

I considered validing that all thing types have models defined somewhere in OppoHandlerFactory and throw so that the binding refuses to start if missing. But since no new models will be released, I guess the risk of adding new thing types and forgetting to add corresponding model is theoretical.

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

jlaur · 2026-08-22T10:30:41Z

+				<description>Mute or unmute the volume on the player</description>
+			</channel>
+			<channel id="source" typeId="source"/>
+			<channel id="play_mode" typeId="play_mode"/>


Fully optional, just a thought: Now that new Things are being introduced, this is the only chance to rename channels to comply with the current naming convention as a non-breaking change:

Suggested change

<channel id="play_mode" typeId="play_mode"/>

<channel id="play-mode" typeId="play_mode"/>

WDYT? The player Thing should of course keep the existing naming then. We can rename all channel types as well as a non-breaking change for player, this only requires update instructions for the player Thing.

That is a good idea, I will work on this tomorrow. All other comments should be addressed now.

jlaur · 2026-08-22T10:36:58Z

+		<parameter name="serialPort" type="text" required="false">
+			<context>serial-port</context>
+			<limitToOptions>false</limitToOptions>
+			<label>Serial Port</label>
+			<description>Serial port to use for connecting to the Oppo player.</description>
+		</parameter>


Does all models have serial ports? Perhaps we could provide two different configurations depending on interface (serial/Ethernet) availability. This would simplify the configuration for each Thing type by removing optional/not applicable parameters.

Yes all models have serial ports and it is the preferred way to talk to them with the exception of the 20x models.

jlaur · 2026-08-22T10:39:03Z

 	xsi:schemaLocation="https://openhab.org/schemas/thing-description/v1.0.0 https://openhab.org/schemas/thing-description-1.0.0.xsd">

-	<!-- Oppo Blu-ray player Thing -->
+	<!-- Generic Oppo Blu-ray player Thing (deprecated) -->


Perhaps this could be extracted to player.xml as well, leaving only the channel type definitions in this file?

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

[oppo] Add discrete thing types & other improvements

9620ac2

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

mlobstein requested a lite review from Copilot August 21, 2026 04:56

mlobstein added the enhancement An enhancement or new feature for an existing add-on label Aug 21, 2026

Copilot started reviewing on behalf of mlobstein August 21, 2026 04:57 View session

Copilot AI reviewed Aug 21, 2026

View reviewed changes

jlaur reviewed Aug 21, 2026

View reviewed changes

review changes

e0fd389

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

mlobstein force-pushed the oppo_things branch from 7a57dac to e0fd389 Compare August 21, 2026 23:30

jlaur reviewed Aug 22, 2026

View reviewed changes

review changes

76b4620

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>

Navigation Menu

Uh oh!

Uh oh!

[oppo] Add discrete thing types & other improvements - #21445

[oppo] Add discrete thing types & other improvements#21445
mlobstein wants to merge 3 commits into
openhab:mainfrom
mlobstein:oppo_things

mlobstein commented Aug 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlaur left a comment

Uh oh!

jlaur Aug 21, 2026

Uh oh!

mlobstein Aug 21, 2026 •

edited

Loading

Uh oh!

jlaur Aug 22, 2026

Uh oh!

Uh oh!

jlaur Aug 22, 2026

Uh oh!

mlobstein Aug 23, 2026

Uh oh!

jlaur Aug 22, 2026

Uh oh!

mlobstein Aug 23, 2026

Uh oh!

jlaur Aug 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<channel id="play_mode" typeId="play_mode"/>
	<channel id="play-mode" typeId="play_mode"/>

Uh oh!

Uh oh!

Conversation

mlobstein commented Aug 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jlaur left a comment

Choose a reason for hiding this comment

Uh oh!

jlaur Aug 21, 2026

Choose a reason for hiding this comment

Uh oh!

mlobstein Aug 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jlaur Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jlaur Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

mlobstein Aug 23, 2026

Choose a reason for hiding this comment

Uh oh!

jlaur Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

mlobstein Aug 23, 2026

Choose a reason for hiding this comment

Uh oh!

jlaur Aug 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mlobstein Aug 21, 2026 •

edited

Loading