Skip to content

Map chart interpolation parameter into sitemap JSON response - #4917

Merged
holgerfriedrich merged 1 commit into
openhab:mainfrom
maniac103:interpolation-fix
Jul 22, 2025
Merged

Map chart interpolation parameter into sitemap JSON response#4917
holgerfriedrich merged 1 commit into
openhab:mainfrom
maniac103:interpolation-fix

Conversation

@maniac103

Copy link
Copy Markdown
Contributor

This was missed in #4610 / commit a9a289e

This was missed in openhab#4610 / commit a9a289e

Signed-off-by: Danny Baumann <dannybaumann@web.de>
@maniac103

Copy link
Copy Markdown
Contributor Author

@mherwege For your review.

@holgerfriedrich holgerfriedrich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich holgerfriedrich added the bug An unexpected problem or unintended behavior of the Core label Jul 21, 2025
@maniac103

Copy link
Copy Markdown
Contributor Author

Not sure about the build failure, as I obviously didn't touch pom.xml.

@holgerfriedrich

Copy link
Copy Markdown
Member

@maniac103 Likely the fail is related to the running release job.
@kaikreuzer has built 5.0 GA build, and we need to settle everythig before a rebase.
The unleash-plugin always breaks the formatting.

@mherwege mherwege left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mherwege mherwege left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich
holgerfriedrich merged commit a4c6b49 into openhab:main Jul 22, 2025
6 of 8 checks passed
@holgerfriedrich holgerfriedrich added this to the 5.1 milestone Jul 22, 2025
@holgerfriedrich

Copy link
Copy Markdown
Member

@openhab/ios-maintainers @openhab/android-maintainers @openhab/webui-maintainers FYI, now the new parameter for chart interpolation should be exported via REST API as well

@lolodomo

Copy link
Copy Markdown
Contributor

Backporting that to 5.0 would be a good idea, WDYT ?

holgerfriedrich pushed a commit that referenced this pull request Aug 16, 2025
This was missed in #4610 / commit a9a289e

Signed-off-by: Danny Baumann <dannybaumann@web.de>
@holgerfriedrich holgerfriedrich added the backported A PR that has been cherry-picked to a patch release branch label Aug 16, 2025
@holgerfriedrich

Copy link
Copy Markdown
Member

@lolodomo thanks for the reminder, done

@timbms

timbms commented Aug 19, 2025

Copy link
Copy Markdown

Can someone please provide the openapi.json file. This helps in preparing the iOS app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of the Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants