Skip to content

[rest] Remove faulty caching from add-on resource - #4925

Merged
holgerfriedrich merged 1 commit into
openhab:mainfrom
florian-h05:addon-rest-caching
Aug 14, 2025
Merged

[rest] Remove faulty caching from add-on resource#4925
holgerfriedrich merged 1 commit into
openhab:mainfrom
florian-h05:addon-rest-caching

Conversation

@florian-h05

Copy link
Copy Markdown
Contributor

Fixes #4834.
Partly reverts #4107.

The caching of the add-on resource is faulty, e.g. changes to the community marketplace settings don't invalidate the cache. As Main UI now better handles add-on store loading, caching is no more needed there.

Fixes openhab#4834.
Partly reverts openhab#4107.

The caching of the add-on resource is faulty, e.g. changes to the community marketplace settings don't invalidate the cache.
As Main UI now better handles add-on store loading, caching is no more needed there.

Signed-off-by: Florian Hotze <dev@florianhotze.com>

@holgerfriedrich holgerfriedrich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerfriedrich
holgerfriedrich merged commit e3ecd8d into openhab:main Aug 14, 2025
4 checks passed
@holgerfriedrich holgerfriedrich added the bug An unexpected problem or unintended behavior of the Core label Aug 14, 2025
@holgerfriedrich holgerfriedrich added this to the 5.1 milestone Aug 14, 2025
@florian-h05
florian-h05 deleted the addon-rest-caching branch August 15, 2025 14:31
@florian-h05

Copy link
Copy Markdown
Contributor Author

Can you please backport?

holgerfriedrich pushed a commit that referenced this pull request Aug 15, 2025
Fixes #4834.
Partly reverts #4107.

The caching of the add-on resource is faulty, e.g. changes to the community marketplace settings don't invalidate the cache.
As Main UI now better handles add-on store loading, caching is no more needed there.

Signed-off-by: Florian Hotze <dev@florianhotze.com>
@holgerfriedrich holgerfriedrich added backported A PR that has been cherry-picked to a patch release branch regression labels Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backported A PR that has been cherry-picked to a patch release branch bug An unexpected problem or unintended behavior of the Core regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changes to filtering criteria for add-ons aren't effective until later

2 participants