Skip to content

Upgrade Karaf from 4.4.7 to 4.4.8 - #4932

Merged
wborn merged 4 commits into
openhab:mainfrom
holgerfriedrich:k448
Aug 9, 2025
Merged

Upgrade Karaf from 4.4.7 to 4.4.8#4932
wborn merged 4 commits into
openhab:mainfrom
holgerfriedrich:k448

Conversation

@holgerfriedrich

@holgerfriedrich holgerfriedrich commented Jul 25, 2025

Copy link
Copy Markdown
Member

RC1 of Karaf 4.4.8 is now under release approval, the tag in git is already available:
https://github.com/apache/karaf/releases/tag/karaf-4.4.8

Upgrade Karaf from 4.4.7 to 4.4.8

  • Sync runtime dependencies with Karaf 4.4.7, most notably:
    • PaxWeb 8.0.33
    • commons-fileupload 1.6.0
    • commons-io 2.20.0
    • commons-lang3 3.18.0
    • JNA 5.17.0
    • XBean 4.27
    • Guava 33.4.8
    • ASM 9.8
    • PaxLogging 2.3.0
    • Xtext/Xtend 2.39.0
    • Bouncy Castle 1.81
    • lsp4j 0.24.0
    • emf.common 2.30.0
    • emf.ecore 2.36
    • emf.ecore.change 2.16.0
    • emf.ecore.xmi 2.37.0
    • guava.failureaccess 1.0.3
    • jose4j 0.9.6
    • logback 1.5.18
  • Resolve itest runbundles

Fixes #4909,
Supersedes #4892, #4894, #4857

@holgerfriedrich
holgerfriedrich force-pushed the k448 branch 2 times, most recently from ff19af1 to ad81dc6 Compare July 28, 2025 16:40
@holgerfriedrich

Copy link
Copy Markdown
Member Author

This is quite far, 448 release notes are already checked into git repo.

@holgerfriedrich

Copy link
Copy Markdown
Member Author

With Karaf 4.4.8, we no longer need to import osgi.core, but could also import more selectively.
This was introduced here:

apache/karaf@b522396

@wborn WDYT, do we need to take this over? I did in this commit for the compile side, but not yet for runtime and test.
9a58767

@holgerfriedrich

Copy link
Copy Markdown
Member Author

OH5.1 binary distribution is available for download from https://github.com/holgerfriedrich/openhab-builds/actions/workflows/k448.yml and can be tested.

* Upgrade Karaf from 4.4.7 to 4.4.8
* Upgrade Xtext/Xtend from 2.37.0 to 2.39.0
* Sync runtime dependencies with Karaf 4.4.7, most notably:
  * PaxWeb 8.0.33
  * commons-fileupload 1.6.0
  * commons-io 2.20.0
  * commons-lang3 3.18.0
  * JNA 5.17.0
  * XBean 4.27
  * Guava 33.4.8
  * ASM 9.8
  * PaxLogging 2.3.0
  * Bouncy Castle 1.81
  * lsp4j 0.24.0
  * emf.common 2.30.0
  * emf.ecore 2.36
  * emf.ecore.change 2.16.0
  * emf.ecore.xmi 2.37.0
  * guava.failureaccess 1.0.3
  * jose4j 0.9.6
  * logback 1.5.18
* Resolve itest runbundles

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich added the rebuild Triggers the Jenkins PR build label Aug 7, 2025
@github-actions github-actions Bot removed the rebuild Triggers the Jenkins PR build label Aug 7, 2025
@holgerfriedrich holgerfriedrich changed the title [WIP] Upgrade Karaf from 4.4.7 to 4.4.8 Upgrade Karaf from 4.4.7 to 4.4.8 Aug 7, 2025
@holgerfriedrich
holgerfriedrich marked this pull request as ready for review August 7, 2025 18:45
@holgerfriedrich
holgerfriedrich requested a review from a team as a code owner August 7, 2025 18:45
@holgerfriedrich

Copy link
Copy Markdown
Member Author

@wborn Karaf is released now, Core PR is ready.
I will rebase add-ons PR and resolve the last resolver issues in add-ons later today.

@holgerfriedrich

Copy link
Copy Markdown
Member Author

Full distro build is available here:
https://github.com/holgerfriedrich/openhab-builds/actions/runs/16813868234
Resolver is fine now.
Distro-Zip and add-ons kar can be downloaded for testing.

Build with tests will be here soon:
https://github.com/holgerfriedrich/openhab-builds/actions/runs/16813877507

@wborn
wborn requested a review from Copilot August 8, 2025 18:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades Apache Karaf from version 4.4.7 to 4.4.8, synchronizing runtime dependencies with the new Karaf version. The upgrade includes multiple dependency version updates and resolves integration test run bundles to maintain compatibility.

  • Updates core Karaf versions from 4.4.7 to 4.4.8
  • Synchronizes numerous runtime dependencies including PaxWeb, commons libraries, JNA, XBean, Guava, ASM, PaxLogging, Xtext/Xtend, Bouncy Castle, lsp4j, and EMF components
  • Resolves integration test bundle version ranges to match updated dependencies

Reviewed Changes

Copilot reviewed 37 out of 37 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
pom.xml Updates Karaf and Xtext version properties
itests/pom.xml Updates logback-classic version for integration tests
Multiple itest.bndrun files Updates dependency version ranges for test bundles
features/karaf/openhab-tp/src/main/feature/feature.xml Updates third-party dependency versions in feature definitions
features/karaf/openhab-tp/pom.xml Updates JNA version property
features/karaf/openhab-core/src/main/feature/feature.xml Updates Xtext and lsp4j version requirements
features/karaf/openhab-core/pom.xml Updates JNA version property
Multiple bundle pom.xml files Updates individual bundle dependency versions
Multiple BOM pom.xml files Updates bill-of-materials dependency versions

Comment thread bundles/org.openhab.core.test/pom.xml
Comment thread bom/compile/pom.xml

@wborn wborn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of the big list of upgrades! 👍 It also worked well after doing some testing. 😃

@wborn
wborn merged commit b8e3dd0 into openhab:main Aug 9, 2025
5 of 8 checks passed
@wborn wborn added the enhancement An enhancement or new feature of the Core label Aug 9, 2025
@wborn wborn added this to the 5.1 milestone Aug 9, 2025
@holgerfriedrich

Copy link
Copy Markdown
Member Author

Thanks, @wborn.
This time we were really lucky. Doing the testing the pre-release versions, I added a few dependency upgrades to Karaf and finally discovered an annoying bug in the logging.
Finally, my build job which can take any Karaf version from git and builds a testable openHAB distro was also very helpful... It does all the resolver stuff on Linux again and prints the results :-)

Lets's see what Karaf 4.5 brings. We can finally expect the upgrade of our outdated Jetty...

@holgerfriedrich
holgerfriedrich deleted the k448 branch August 9, 2025 19:40
florian-h05 pushed a commit to openhab/openhab-webui that referenced this pull request Aug 10, 2025
Refs openhab/openhab-core#4932.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Aug 26, 2025
This was updated to wrong version in openhab#4932.
Downgrade from 3.19.0 to 3.18.0 to sync with Karaf 4.4.8.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Aug 26, 2025
This was updated to a wrong version in openhab#4932.
Downgrade from 3.19.0 to 3.18.0 to sync with Karaf 4.4.8.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich added a commit to holgerfriedrich/openhab-core that referenced this pull request Aug 27, 2025
This was updated to a wrong version in openhab#4932.
Downgrade from 3.19.0 to 3.18.0 to sync with Karaf 4.4.8.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
wborn pushed a commit that referenced this pull request Aug 30, 2025
This was updated to a wrong version in #4932.
Downgrade from 3.19.0 to 3.18.0 to sync with Karaf 4.4.8.

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement An enhancement or new feature of the Core

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrading XText

3 participants