Skip to content

# Refactor ThingStatusTriggerHandler for improved clarity and modernization - #4938

Merged
holgerfriedrich merged 1 commit into
openhab:mainfrom
OlegAndreych:thing-status-trigger-handler-cleanup
Aug 1, 2025
Merged

# Refactor ThingStatusTriggerHandler for improved clarity and modernization#4938
holgerfriedrich merged 1 commit into
openhab:mainfrom
OlegAndreych:thing-status-trigger-handler-cleanup

Conversation

@OlegAndreych

Copy link
Copy Markdown
Contributor
  • Removed unnecessary instance fields (thingUID and bundleContext) and replaced with local variables where appropriate.
  • Simplified eventTopicFilter initialization by using local thingUID variable.
  • Applied pattern matching for instanceof to reduce explicit casting in receive() method.
  • Cleaned up unused code and improved readability.

@OlegAndreych
OlegAndreych requested a review from a team as a code owner July 31, 2025 21:03
…zation

- Removed unnecessary instance fields (`thingUID` and `bundleContext`) and replaced with local variables where appropriate.
- Simplified `eventTopicFilter` initialization by using local `thingUID` variable.
- Applied pattern matching for `instanceof` to reduce explicit casting in `receive()` method.
- Cleaned up unused code and improved readability.

Signed-off-by: Oleg Andreych <kjiec4@gmail.com>
@OlegAndreych
OlegAndreych force-pushed the thing-status-trigger-handler-cleanup branch from 6008097 to b39ac31 Compare July 31, 2025 21:04

@holgerfriedrich holgerfriedrich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@holgerfriedrich
holgerfriedrich merged commit 511f758 into openhab:main Aug 1, 2025
4 checks passed
@holgerfriedrich holgerfriedrich added this to the 5.1 milestone Aug 1, 2025
@lolodomo

Copy link
Copy Markdown
Contributor

@holgerfriedrich : no label set was intentional ?

@holgerfriedrich

holgerfriedrich commented Aug 16, 2025

Copy link
Copy Markdown
Member

@lolodomo yes, this should not change any visible functionality, we could tag as enhancement if you like

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants