Downgrade hivemq-client-mqtt to 1.3.7, netty 4.1.122 - #4976
Merged
Conversation
This reverts commit f23304e. Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich
force-pushed
the
pr-netty-for-137
branch
from
August 24, 2025 09:12
206cd15 to
a16afcc
Compare
Member
Author
|
Finally build of core and add-ons completed, itests are fine again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hivemq-client-mqtt 1.3.8 does lead to failing itests in add-ons repo (mqtt.homeassistant, mqtt.homie, mqtt.ruuvygateway), due to issue with transitive dependency dagger. I could not make it work until now, so I propose to revert the upgrade to 1.3.8 and stay with the also recently introduced 1.3.7.
This PR upgrades netty to 4.1.122 to match hivemq. This was missing in #4958.
Please do not squash during merge.