Skip to content

Upgrade Xtext/Xtend to 2.40 - #4981

Merged
wborn merged 2 commits into
openhab:mainfrom
holgerfriedrich:pr-xtend3
Aug 30, 2025
Merged

Upgrade Xtext/Xtend to 2.40#4981
wborn merged 2 commits into
openhab:mainfrom
holgerfriedrich:pr-xtend3

Conversation

@holgerfriedrich

Copy link
Copy Markdown
Member
  • Upgrade Xtext/Xtend from 2.39 to 2.40
  • Upgrade gson from 2.11.0 to 2.13.1
  • Upgrade classgraph 4.8.176 to 4.8.180
  • Change repo from org.eclipse.xtend to org.eclipse.xtext

* Upgrade Xtext/Xtend from 2.39 to 2.40
* Upgrade gson from 2.11.0 to 2.13.1
* Upgrade classgraph 4.8.176 to 4.8.180
* Change repo from org.eclipse.xtend to org.eclipse.xtext

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@wborn
wborn merged commit 7d8aca4 into openhab:main Aug 30, 2025
4 checks passed
@wborn wborn added this to the 5.1 milestone Aug 30, 2025
@holgerfriedrich
holgerfriedrich deleted the pr-xtend3 branch August 30, 2025 14:05
@florian-h05

Copy link
Copy Markdown
Contributor

@holgerfriedrich My Fronius Wattpilot Binding is using my wattpilot4j library that is using Gson 2.11.0. wattpilot4j is deployed as OSGi bundle.
Do I now need to update it or will it run fine when requiring Gson 2.11.0?

@holgerfriedrich

holgerfriedrich commented Aug 30, 2025

Copy link
Copy Markdown
Member Author

@florian-h05 I don't remember any issues we had before when updating xtext libraries. I did this a few times before... But maybe we were just lucky.

I will need to have a look at add-ons later today. Currently build of the combined PR (all changes merged today) fails with a strange error.

@florian-h05

Copy link
Copy Markdown
Contributor

The Xtext upgrade doesn’t matter, if anything is causing trouble for me, then the Gson upgrade.
I will see in the next snapshots.

@holgerfriedrich

holgerfriedrich commented Aug 31, 2025

Copy link
Copy Markdown
Member Author

This upgrade seems to have broken the LSP service. The logs of a full distro start show something like this:

14:00:14.142 [ERROR] [b.core.model.lsp.internal.ModelServer] - bundle org.openhab.core.model.lsp:5.1.0.202508311151 (202)[org.openhab.core.model.lsp.internal.ModelServer(222)] : Error during instantiation of the implementation object java.lang.reflect.InvocationTargetException: null

Caused by: com.google.inject.CreationException: Unable to create injector, see the following errors:
[Guice/MissingImplementation]: No implementation for IRequestManager was bound.
Requested by:
1  : LanguageServerImpl.requestManager(LanguageServerImpl.java:163)
      \_ for field requestManager
     at RuntimeServerModule.configure(RuntimeServerModule.java:57)

Learn more:
  https://github.com/google/guice/wiki/MISSING_IMPLEMENTATION

@holgerfriedrich

Copy link
Copy Markdown
Member Author

@florian-h05 IIRC gson upgrades are done together with xtext... this is why I mentioned it.

@holgerfriedrich holgerfriedrich added the dependencies Pull requests that update a dependency file label Sep 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants